Fix issue 430#1297
Merged
itsalaidbacklife merged 7 commits intocuttle-cards:mainfrom Dec 2, 2025
Merged
Conversation
- Created src/components/BaseOverlay.vue with shared overlay styles - Refactored GameUnavailableOverlay.vue to use BaseOverlay - Refactored GameOverlays.vue to use BaseOverlay - Removed duplicate CSS from both files Fixes cuttle-cards#430
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses code duplication by creating a reusable BaseOverlay component that consolidates overlay styling previously duplicated across multiple game overlay components.
- Created a centralized
BaseOverlaycomponent with consistent styling and slot-based content injection - Refactored 8 existing overlays to use the new
BaseOverlaycomponent - Removed 36 lines of duplicate CSS code from two files
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/components/BaseOverlay.vue | New reusable overlay component with header slot and consistent styling |
| src/routes/game/components/GameUnavailableOverlay.vue | Refactored to use BaseOverlay, removing duplicate CSS |
| src/routes/game/components/GameOverlays.vue | Converted 7 overlays to use BaseOverlay, removing duplicate CSS |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
itsalaidbacklife
previously approved these changes
Dec 2, 2025
Contributor
itsalaidbacklife
left a comment
itsalaidbacklife
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
itsalaidbacklife
added
frontend
itsalaidbacklife
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #430
Summary
Created a reusable
BaseOverlaycomponent to consolidate duplicate overlay styles that were previously duplicated across multiple files.Changes
src/components/BaseOverlay.vue- A reusable overlay component with consistent styling and slots for header and contentsrc/routes/game/components/GameUnavailableOverlay.vueto use BaseOverlaysrc/routes/game/components/GameOverlays.vueto use BaseOverlay (7 overlays converted)Issue number
BaseOverlaycomponent to apply consistent styles to overlays throughout the app #430Please check the following
Please describe additional details for testing this change
The BaseOverlay component consolidates styling from existing overlays. All overlay functionality remains the same, only the implementation changed. To test: