Skip to content

test(profile.spec.js): add waits and more explicit assertions to slow down scroll#1301

Merged
itsalaidbacklife merged 2 commits intomainfrom
test/flaky-profile-spec
Dec 2, 2025
Merged

test(profile.spec.js): add waits and more explicit assertions to slow down scroll#1301
itsalaidbacklife merged 2 commits intomainfrom
test/flaky-profile-spec

Conversation

@itsalaidbacklife
Copy link
Copy Markdown
Contributor

Follow up to previous PR on the same spec which appeared not to get it. So far this looks to be working

Issue number

Relevant issue number

  • Resolves #

Please check the following

  • Do the tests still pass? (see Run the Tests)
  • Is the code formatted properly? (see Linting (Formatting))
  • For New Features:
    • Have tests been added to cover any new features or fixes?
    • Has the documentation been updated accordingly?

Please describe additional details for testing this change

@itsalaidbacklife itsalaidbacklife added dev experience Improvements to the code base that make it easier/better/more enjoyable to contribute to Cuttle version-patch An update that warrants a bumping the project's patch version (e.g. 4.0.0 => 4.0.1) labels Dec 2, 2025
.should('be.visible')
.scrollIntoView();

cy.wait(1000);
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like adding this wait, but I've tried as many assertions as I can think of to get it to be consistent and I haven't been successful

@itsalaidbacklife itsalaidbacklife merged commit af6d250 into main Dec 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev experience Improvements to the code base that make it easier/better/more enjoyable to contribute to Cuttle version-patch An update that warrants a bumping the project's patch version (e.g. 4.0.0 => 4.0.1)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant