Skip to content

fix(rulesData.js): revise urls to all utilize github pages CDN#1307

Merged
itsalaidbacklife merged 2 commits into
mainfrom
fix/pull-assets-from-pages
Dec 11, 2025
Merged

fix(rulesData.js): revise urls to all utilize github pages CDN#1307
itsalaidbacklife merged 2 commits into
mainfrom
fix/pull-assets-from-pages

Conversation

@itsalaidbacklife
Copy link
Copy Markdown
Contributor

Fixes bug where images wouldn't load from the cuttle-assets repo (https://cloud.cypress.io/projects/i8bxr8/runs/3086/overview/148dc19c-34a9-43a6-9e06-fc5574e36b04/replay?roarHideRunsWithDiffGroupsAndTags=1&runStatus=FAILED&runStatus=RUNNING&runStatus=CANCELLED&runStatus=ERRORED&runStatus=OVERLIMIT&runStatus=PASSED&ts=1765463068812&att=1) due to incorrectly using githubs ?raw api instead of a proper github pages deployment of the assets repo

Issue number

Relevant issue number

  • Resolves #

Please check the following

  • Do the tests still pass? (see Run the Tests)
  • Is the code formatted properly? (see Linting (Formatting))
  • For New Features:
    • Have tests been added to cover any new features or fixes?
    • Has the documentation been updated accordingly?

Please describe additional details for testing this change

@itsalaidbacklife itsalaidbacklife added frontend Requires changes to the frontend (vue) client bug Something isn't working version-patch An update that warrants a bumping the project's patch version (e.g. 4.0.0 => 4.0.1) labels Dec 11, 2025
…o ranked or casual') spec with DOM assertions
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's kindof ridiculous that we had it this way previously. I updated the cuttle-assets repo to publish to github pages for a more official/accepted way to use GH as a CDN.'

We started getting 503 errors and being rate limited with what's here. This should be more legit now

Comment thread tests/e2e/specs/out-of-game/lobby.spec.js
@itsalaidbacklife itsalaidbacklife merged commit b56a72d into main Dec 11, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend Requires changes to the frontend (vue) client version-patch An update that warrants a bumping the project's patch version (e.g. 4.0.0 => 4.0.1)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant