Skip to content

Drop support for the GET /api/tasks/<id>/status API#9076

Closed
Marishka17 wants to merge 6 commits intodevelopfrom
mk/drop_task_status_api
Closed

Drop support for the GET /api/tasks/<id>/status API#9076
Marishka17 wants to merge 6 commits intodevelopfrom
mk/drop_task_status_api

Conversation

@Marishka17
Copy link
Contributor

@Marishka17 Marishka17 commented Feb 7, 2025 •
edited
Loading

Motivation and context

The GET /api/tasks/<id>/status API endpoint was previously deprecated in favor of GET /api/requests/<rq_id>
Extracted from #9075

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@Marishka17 Marishka17 requested a review from SpecLad as a code owner February 7, 2025 19:28
@Marishka17 Marishka17 requested a review from nmanovic as a code owner February 7, 2025 19:33
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.16%. Comparing base (2f110e5) to head (026f658).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #9076      +/-   ##
===========================================
- Coverage    74.17%   74.16%   -0.01%     
===========================================
  Files          428      428              
  Lines        44964    44931      -33     
  Branches      3917     3917              
===========================================
- Hits         33352    33325      -27     
+ Misses       11612    11606       -6
Components Coverage Δ
cvat-ui 77.23% <ø> (-0.01%) ⬇️
cvat-server 71.62% <ø> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Marishka17
Copy link
Contributor Author

Marishka17 commented Feb 10, 2025

Before merging this PR, we need to switch the Exchange Oracle from Human Protocol to the requests API.
FYI: @zhiltsov-max

@SpecLad
Copy link
Contributor

SpecLad commented Feb 10, 2025

Before merging this PR, we need to switch the Exchange Oracle from Human Protocol to the requests API. FYI: @zhiltsov-max

I'll convert it to draft then, to prevent mistakes. Please convert it back when it's safe to merge.

@SpecLad SpecLad marked this pull request as draft February 10, 2025 11:04
SpecLad
SpecLad reviewed Feb 13, 2025
View reviewed changes
cvat/apps/engine/tests/test_rest_api.py Outdated
Comment on lines 3528 to 3529
expected_task_creation_status_state='finished',
expected_task_creation_status_reason=None,
Copy link
Contributor

@SpecLad SpecLad Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you could change "status" to "request"/"rq" here? Seems like it would match the terminology better.

@Marishka17 Marishka17 force-pushed the mk/drop_task_status_api branch from 98f02f3 to 5a343b1 Compare February 13, 2025 15:16
@Marishka17
Copy link
Contributor Author

Marishka17 commented Feb 13, 2025

/check

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

❌ Some checks failed
📄 See logs here

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 13, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zhiltsov-max
Copy link
Contributor

zhiltsov-max commented Mar 24, 2025

HP was updated in humanprotocol/human-protocol#3219

@Marishka17 Marishka17 marked this pull request as ready for review March 24, 2025 10:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 24, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mjohenneken mjohenneken mentioned this pull request Apr 14, 2025
Open
2 tasks
@Marishka17 Marishka17 closed this Jul 17, 2025
@Marishka17 Marishka17 deleted the mk/drop_task_status_api branch July 17, 2025 15:08
@bsekachev bsekachev restored the mk/drop_task_status_api branch July 21, 2025 09:43
@bsekachev bsekachev reopened this Jul 21, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 21, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@bsekachev bsekachev closed this Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SpecLad SpecLad SpecLad approved these changes

@nmanovic nmanovic Awaiting requested review from nmanovic nmanovic is a code owner

Assignees

No one assigned

Labels

server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Marishka17 @codecov-commenter @SpecLad @zhiltsov-max @bsekachev

Comments