[Refactoring] Update id naming convention#9206
Closed
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #9206 +/- ##
===========================================
- Coverage 74.14% 74.13% -0.01%
===========================================
Files 428 428
Lines 44973 44971 -2
Branches 3917 3917
===========================================
- Hits 33345 33340 -5
- Misses 11628 11631 +3
🚀 New features to boost your workflow:
|
|
Member
First of all, I can't remember any discussions regarding naming conventions. Anyway, we may follow Id, or ID, it is discussable (chat GPT recommends using
|
Contributor
Author
|
Patch needs to be reworked, I will close it for now till I have time to finish it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation and context
For a long time we now have been using
*IDnaming convention for id variables, but in some code that was added before this, some variables keep*Idnaming convention. This PR tries to unify it.How has this been tested?
Checklist
developbranch[ ] I have created a changelog fragment-~~ [ ] I have updated the documentation accordingly~~
[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)License
Feel free to contact the maintainers if that's a concern.