43: Support both this.db and this.knex #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Can you not "deprecate" .db and instead simply add support for .knex? |
Contributor
Author
|
@cvburgess updated. Lmk if I should change back the README examples as well |
cvburgess
approved these changes
Dec 30, 2019
Owner
|
thank you for this! Please update the version number in package.json and package-lock.json and I will merge |
Contributor
Author
|
done, thanks
…On Mon, Dec 30, 2019 at 6:50 PM Charles Burgess ***@***.***> wrote:
thank you for this! Please update the version number in package.json and
package-lock.json and I will merge
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#44?email_source=notifications&email_token=AAB5LGALT34LNLHJ4GN7AODQ3KCMJA5CNFSM4KBQJDS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH3ORMI#issuecomment-569829553>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB5LGER5TZFSD3ZMQYKSU3Q3KCMJANCNFSM4KBQJDSQ>
.
|
cvburgess
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.