Small fixes: Fix 'gauge' typo, quote label fields #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcpunk
approved these changes
Jun 28, 2025
Collaborator
|
Looks good to me. My test box only has two mounted repos, but anything you're able to do to improve the performance would be great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried out the script with prometheus 3.4.2 and had to fix two small issues to get it to work.
On a machine with 10 repos mounted it's also pretty slow, takes about 20s per scrape. I think I can adapt cvmfs_talk to output this format directly, similar to the telemetry aggregator that exists for influxdb. That probably removes a lot of overhead and makes the script much more simple. Stay tuned