This repository was archived by the owner on Jul 23, 2024. It is now read-only.
Scheduler refactoring #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@jnv review plz |
tszolar
force-pushed
the
scheduler_refactoring
branch
from
ccaecba to
1b2743a
Compare
config/initializers/logging.rb
Outdated
Contributor
There was a problem hiding this comment.
I suppose this could use Config.rack_env so there's a guaranteed default, but this is also fine.
Contributor
|
My original idea was that you would put the shared sequence into ScheduleManager, but I suppose this can also work. Just make sure invocation from scheduler does work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have refactored scheduler script a bit to use
sirius:eventsrake task instead of calling ScheduleManager directly.Also the logging gem was added to improve logging in scheduler and rake tasks.