Skip to content

importing-abcs-deprecation(2)#207

Closed
thinkJD wants to merge 1 commit intocwacek:masterfrom
thinkJD:patch-1
Closed

importing-abcs-deprecation(2)#207
thinkJD wants to merge 1 commit intocwacek:masterfrom
thinkJD:patch-1

Conversation

@thinkJD
Copy link
Copy Markdown
Contributor

@thinkJD thinkJD commented Mar 4, 2021

fixing Python 3.8 ABC deprecation

last pull request did not solve the problem.

fixing Python 3.8 ABC deprecation
@thinkJD
Copy link
Copy Markdown
Contributor Author

thinkJD commented Mar 4, 2021

I don't know why the linter fails. If i see this right it's not about my change.

@cwacek
Copy link
Copy Markdown
Owner

cwacek commented Mar 12, 2021

The linter was failing because GH was running a different version than the precommit hook, and I guess it changed. I pinned that and pulled that change in. We'll see if it passes now

@cwacek
Copy link
Copy Markdown
Owner

cwacek commented Mar 12, 2021

Ah, PRs. I can't push to the PR branch - so you'll have to pull
master and push.

@cwacek cwacek mentioned this pull request Mar 26, 2021
@cwacek
Copy link
Copy Markdown
Owner

cwacek commented Mar 26, 2021

See #211

@cwacek cwacek closed this Mar 26, 2021
cwacek added a commit that referenced this pull request Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants