Supporting Circular References#97
Closed
omerbn wants to merge 8 commits intocwacek:masterfrom
omerbn:master
Closed
Supporting Circular References#97omerbn wants to merge 8 commits intocwacek:masterfrom omerbn:master
omerbn wants to merge 8 commits intocwacek:masterfrom
omerbn:master
Conversation
added 8 commits
September 17, 2017 16:50
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example:
class A has property of type Class B
Class B has property of type Class A
This causes stack-overflow due to recursions.
Solution:
My fix suggests to set placeholders where there are references to current-during-build classes, and fill these placeholders upon finish.
Notes:
I had many commits as I tried to match forked:master indentation.
I accidentally committed something and removed it in following commit.