Skip to content

fix: [1078] 譜面明細子画面のショートカットキーの下キーの初期カーソル位置誤りを修正#2093

Merged
cwtickle merged 1 commit intodevelopfrom
hotfix/1078-score-detail-cursor
May 3, 2026
Merged

fix: [1078] 譜面明細子画面のショートカットキーの下キーの初期カーソル位置誤りを修正#2093
cwtickle merged 1 commit intodevelopfrom
hotfix/1078-score-detail-cursor

Conversation

@cwtickle
Copy link
Copy Markdown
Owner

@cwtickle cwtickle commented May 3, 2026

🔨 変更内容 / Details of Changes

1. 譜面明細子画面のショートカットキーの下キーの初期カーソル位置誤りを修正

  • 譜面明細子画面のショートカットキーの下キーについて、初期位置に誤りがあり、
    初回のみ下キーを2回押さないと次の明細にならないようになっていました。

🔖 関連Issue, 変更理由 / Related Issues, Reason for Changes

  1. PR improve: [1076] 譜面明細子画面を内部的にページとして分離 #2090 の考慮漏れです。

📷 スクリーンショット / Screenshot

📝 その他コメント / Other Comments

@cwtickle cwtickle added bug Something isn't working func10:Settings 設定画面全般 labels May 3, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f9162770-5c23-42b1-a120-31724eff2dce

📥 Commits

Reviewing files that changed from the base of the PR and between e867c8b and 5cf4dd7.

📒 Files selected for processing (1)
  • js/danoni_main.js

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced ArrowDown key navigation in the score detail page. The key now properly cycles through focus targets sequentially instead of consistently returning to the initial item.

Walkthrough

The scoreDetail page's ArrowDown shortcut target was changed from always using the first cursor position to dynamically navigating through available cursor positions using the nextPos() function, enabling cycling through multiple targets instead of a fixed selection.

Changes

Shortcut Navigation Update

Layer / File(s) Summary
Shortcut Wiring
js/danoni_main.js
g_shortcutObj.scoreDetail.ArrowDown.id updated to use nextPos(0, 1, g_settings.scoreDetailCursorsOrg.length) instead of hardcoded g_settings.scoreDetailCursorsOrg[0], enabling dynamic cursor position cycling.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main fix: correcting the initial cursor position error for the down arrow shortcut key in the score detail subscreens, which matches the changeset modification to the ArrowDown cursor initialization logic.
Description check ✅ Passed The description is directly related to the changeset, detailing the bug in the score detail subscreens where the down arrow key required two presses initially, and referencing PR #2090 as the source of the oversight being corrected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hotfix/1078-score-detail-cursor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@cwtickle cwtickle merged commit 9527b5e into develop May 3, 2026
4 checks passed
@cwtickle cwtickle deleted the hotfix/1078-score-detail-cursor branch May 4, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working func10:Settings 設定画面全般

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant