improve: [1096] 譜面明細子画面、FrzReturn用ゲージのCSSカスタムプロパティを分離#2119
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR renames and introduces dedicated CSS classes for the FrzReturn frozen-life-gauge states and result-screen common label colors. New selectors are added to the main stylesheet, class assignments are updated in JavaScript, the class names are registered in the constants mapping, and skin template placeholders are inserted across all theme files. ChangesCSS Class Naming Refactor for FrzReturn Life Gauge and Result Labels
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
skin/danoni_skin_light.css (1)
73-76:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFix CSS comment formatting for consistency.
Same formatting issue as in
danoni_skin_default.css: commented-out CSS variable placeholders need a space after/*to comply with stylelint rules and match the existing comment style in this file.🎨 Proposed formatting fix
/* 譜面明細子画面: ハイスコア表示 */ - /*--settings-assist-x: var(--common-kita); */ - /*--settings-another-x: var(--common-ii); */ + /* --settings-assist-x: var(--common-kita); */ + /* --settings-another-x: var(--common-ii); *//* ライフゲージ: FrzReturn用 */ - /*--life-frz-normal: var(--main-stepShobon); */ - /*--life-frz-active: var(--main-stepMatari); */ + /* --life-frz-normal: var(--main-stepShobon); */ + /* --life-frz-active: var(--main-stepMatari); */Also applies to: 123-126
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skin/danoni_skin_light.css` around lines 73 - 76, The CSS comments containing commented-out variable placeholders (e.g. "/*--settings-assist-x: var(--common-kita); */" and "/*--settings-another-x: var(--common-ii); */") should be reformatted to include a space after the opening /* to match the file's comment style and satisfy stylelint; update these occurrences (including the similar ones at the later occurrence around the 123-126 range) so they read like "/* --settings-... */" with a space after /* and before */ where appropriate.skin/danoni_skin_skyblue.css (1)
73-76:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFix CSS comment formatting for consistency.
Same formatting issue as in the other skin files: commented-out CSS variable placeholders need a space after
/*to comply with stylelint rules and maintain consistency.🎨 Proposed formatting fix
/* 譜面明細子画面: ハイスコア表示 */ - /*--settings-assist-x: var(--common-kita); */ - /*--settings-another-x: var(--common-ii); */ + /* --settings-assist-x: var(--common-kita); */ + /* --settings-another-x: var(--common-ii); *//* ライフゲージ: FrzReturn用 */ - /*--life-frz-normal: var(--main-stepShobon); */ - /*--life-frz-active: var(--main-stepMatari); */ + /* --life-frz-normal: var(--main-stepShobon); */ + /* --life-frz-active: var(--main-stepMatari); */Also applies to: 123-126
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skin/danoni_skin_skyblue.css` around lines 73 - 76, The commented-out CSS variable placeholders (e.g. --settings-assist-x and --settings-another-x) use "/*" directly against the text; update each comment to include a space after "/*" (and keep the trailing " */") so they read like "/* --settings-... */" for stylelint consistency; apply the same change to the other occurrences mentioned (around the --settings-* placeholders at the later block).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skin/danoni_skin_default.css`:
- Around line 73-76: The block containing the commented CSS variables
(--settings-assist-x and --settings-another-x) has comments starting with "/*"
immediately followed by text; update those comments to include a single space
after the opening "/*" to satisfy the comment-whitespace-inside rule and match
the style used elsewhere (e.g., change "/*--settings-assist-x:
var(--common-kita);" and "/*--settings-another-x: var(--common-ii);" to use "/*
--settings-assist-x: var(--common-kita);" and "/* --settings-another-x:
var(--common-ii);"); apply the same spacing fix to the similar commented lines
at the later block referenced (lines 123-126).
---
Duplicate comments:
In `@skin/danoni_skin_light.css`:
- Around line 73-76: The CSS comments containing commented-out variable
placeholders (e.g. "/*--settings-assist-x: var(--common-kita); */" and
"/*--settings-another-x: var(--common-ii); */") should be reformatted to include
a space after the opening /* to match the file's comment style and satisfy
stylelint; update these occurrences (including the similar ones at the later
occurrence around the 123-126 range) so they read like "/* --settings-... */"
with a space after /* and before */ where appropriate.
In `@skin/danoni_skin_skyblue.css`:
- Around line 73-76: The commented-out CSS variable placeholders (e.g.
--settings-assist-x and --settings-another-x) use "/*" directly against the
text; update each comment to include a space after "/*" (and keep the trailing "
*/") so they read like "/* --settings-... */" for stylelint consistency; apply
the same change to the other occurrences mentioned (around the --settings-*
placeholders at the later block).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 8412fe6f-3c98-4deb-a0dd-8c0113673272
📒 Files selected for processing (6)
css/danoni_main.cssjs/danoni_main.jsjs/lib/danoni_constants.jsskin/danoni_skin_default.cssskin/danoni_skin_light.cssskin/danoni_skin_skyblue.css
1 participant
🔨 変更内容 / Details of Changes
1. 譜面明細子画面、FrzReturn用ゲージのCSSカスタムプロパティを分離
入れ替えは必須ではありません。
🔖 関連Issue, 変更理由 / Related Issues, Reason for Changes
📷 スクリーンショット / Screenshot
📝 その他コメント / Other Comments