Skip to content

improve: [1099] Display設定のショートカットキー変更、メッセージ文の見直し#2124

Merged
cwtickle merged 1 commit into
developfrom
feature/1099-display-key
May 23, 2026
Merged

improve: [1099] Display設定のショートカットキー変更、メッセージ文の見直し#2124
cwtickle merged 1 commit into
developfrom
feature/1099-display-key

Conversation

@cwtickle
Copy link
Copy Markdown
Owner

🔨 変更内容 / Details of Changes

1. Display設定のショートカットキー変更、メッセージ文の見直し

  • Display設定のショートカットキーを変更しました。
  • 6~0をVelocity~Specialに割り当て、セミコロンはFilterLineに割り当てました。
  • また、機能統合により一部メッセージを見直す必要があり、補足しました。

🔖 関連Issue, 変更理由 / Related Issues, Reason for Changes

  1. FIlterLineはHidden+/Sudden+時のみ使用できるオプションであるため、
    割当先を変えることでわかりやすくしました。

📷 スクリーンショット / Screenshot

image

📝 その他コメント / Other Comments

@cwtickle cwtickle added the func10:Settings 設定画面全般 label May 23, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 23, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5900e1bf-3037-411c-b42b-be4a86f5d4a0

📥 Commits

Reviewing files that changed from the base of the PR and between be450e2 and 4fb1bd1.

📒 Files selected for processing (1)
  • js/lib/danoni_constants.js

📝 Walkthrough

Summary by CodeRabbit

  • Documentation

    • Updated descriptions for display options (judgment, background, lyrics) in Japanese and English to better clarify their behavior and interaction with other settings
  • Chores

    • Reorganized keyboard shortcut mappings for the settings display screen

Walkthrough

This PR updates keyboard shortcut mappings and localization text in the constants file. Digit and numpad keys are remapped to different display option targets; Japanese descriptions and English localization strings for display options are reworded to clarify their behavioral semantics.

Changes

Settings Display Configuration

Layer / File(s) Summary
Keyboard shortcut mappings for settings display
js/lib/danoni_constants.js
Digit-key (Digit6Digit0, Semicolon) and numpad-key (Numpad6Numpad0, NumpadAdd) shortcuts in g_shortcutObj.settingsDisplay are remapped to different UI element IDs for display options such as velocity, color, background, arrow effects, special effects, and filter lines.
Localization strings for display options
js/lib/danoni_constants.js
Japanese descriptions for d_judgment and d_background are reworded to specify Fast/Slow-only and lyrics-only display behaviors respectively. English localization entries consolidate and rework d_judgment, d_color, and d_background text while removing separate d_fastslow and d_lyrics entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • cwtickle/danoniplus#2090: Updates keyboard shortcut mappings in g_shortcutObj for a different screen (scoreDetail), demonstrating a related pattern of shortcut remapping in the same constants file.
  • cwtickle/danoniplus#2121: Contains overlapping changes to danoni_constants.js shortcut remaps and display-option localization strings, directly addressing the same configuration areas.
  • cwtickle/danoniplus#2095: Modifies display-option localization entries (d_judgment and related d_* strings) in the same constants file, sharing direct code-level overlap.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating keyboard shortcuts for the Display settings screen and revising message text.
Description check ✅ Passed The description is directly related to the changeset, detailing the keyboard shortcut reassignments and message text updates with clear rationale.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/1099-display-key

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cwtickle cwtickle merged commit 9557f01 into develop May 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

func10:Settings 設定画面全般

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant