Skip to content

[+] introduce new type metrics.MetricIntervals#1312

Merged
pashagolub merged 1 commit intomasterfrom
add-metric-intervals-type
Mar 18, 2026
Merged

[+] introduce new type metrics.MetricIntervals#1312
pashagolub merged 1 commit intomasterfrom
add-metric-intervals-type

Conversation

@pashagolub
Copy link
Collaborator

We want to change it to map[string]int instead of map[string]float64 and use the type name everywhere in code base to make the purpose of vars obvious

We want to change it to `map[string]int` instead of `map[string]float64`
and use the type name everywhere in code base to make the purpose of
vars obvious
@pashagolub pashagolub self-assigned this Mar 18, 2026
@pashagolub pashagolub added the refactoring Something done as it should've been done from the start label Mar 18, 2026
@coveralls
Copy link

Pull Request Test Coverage Report for Build 23243112556

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 4 files are covered.
  • 35 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.6%) to 83.48%

Files with Coverage Reduction New Missed Lines %
internal/reaper/reaper.go 4 37.04%
internal/reaper/logparser_remote.go 31 34.91%
Totals Coverage Status
Change from base Build 23228867861: -0.6%
Covered Lines: 4568
Relevant Lines: 5472

💛 - Coveralls

@pashagolub pashagolub merged commit 3519398 into master Mar 18, 2026
9 checks passed
@pashagolub pashagolub deleted the add-metric-intervals-type branch March 18, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Something done as it should've been done from the start

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants