Skip to content

[+] add SQL syntax highlighting to webui InitSQL popup#1317

Merged
pashagolub merged 2 commits intocybertec-postgresql:masterfrom
mohamadyasser118:feat/Initsql-popup-readability-improvement
Mar 20, 2026
Merged

[+] add SQL syntax highlighting to webui InitSQL popup#1317
pashagolub merged 2 commits intocybertec-postgresql:masterfrom
mohamadyasser118:feat/Initsql-popup-readability-improvement

Conversation

@mohamadyasser118
Copy link
Contributor

Description

I find it quite difficult to read the InitSQL popup

The improvement is minimal, the type === "sql" branch currently renders a plain <pre> block. I just replace that with SyntaxHighlighter, exactly like we did in SqlPopUp.consts.tsx. The Box wrapper and dialog structure stay completely untouched.

Before:

Screenshot 2026-03-19 220632

After:

image

AI & Automation Policy

  • I am the human author and take full personal responsibility for every change in this PR.
  • No AI or automated generative tool was used in any part of this PR OR I have disclosed all tool(s) below.
    Drafted with the assistance of Claude.

Checklist

  • Code compiles and existing tests pass locally.
  • New or updated tests are included where applicable.
  • Documentation is updated where applicable.

@pashagolub pashagolub changed the title feat(webui): add SQL syntax highlighting to InitSQL popup [+] add SQL syntax highlighting to InitSQL popup in webui Mar 20, 2026
@pashagolub pashagolub changed the title [+] add SQL syntax highlighting to InitSQL popup in webui [+] add SQL syntax highlighting to webui InitSQL popup Mar 20, 2026
@pashagolub pashagolub self-assigned this Mar 20, 2026
@pashagolub pashagolub added the webui Admin UI related issues label Mar 20, 2026
@pashagolub
Copy link
Collaborator

thanks!

Copy link
Collaborator

@pashagolub pashagolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pashagolub pashagolub merged commit 98c7c13 into cybertec-postgresql:master Mar 20, 2026
5 checks passed
@mohamadyasser118 mohamadyasser118 deleted the feat/Initsql-popup-readability-improvement branch March 20, 2026 14:21
@Mazen050
Copy link
Contributor

Hello @mohamadyasser118 , I just have a small question. is there a reason we use the full build here and the light build in the other sql highlighter view? for me it would make sense to make them consistent and use the light build if we don't need the full version to avoid unnecessary bundle size increase. (also since we need to support one language)

@mohamadyasser118
Copy link
Contributor Author

Hello @mohamadyasser118 , I just have a small question. is there a reason we use the full build here and the light build in the other sql highlighter view? for me it would make sense to make them consistent and use the light build if we don't need the full version to avoid unnecessary bundle size increase. (also since we need to support one language)

Hello Mazen, Actually the bundle impact is minimal in practice, so there is no big difference ..
but this can be a good enhancement if you want to make,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

webui Admin UI related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants