[*] refactor EnabledSourceSwitch#1319
Open
Mazen050 wants to merge 1 commit intocybertec-postgresql:masterfrom
Open
[*] refactor EnabledSourceSwitch#1319Mazen050 wants to merge 1 commit intocybertec-postgresql:masterfrom
EnabledSourceSwitch#1319Mazen050 wants to merge 1 commit intocybertec-postgresql:masterfrom
Conversation
f6753df to
6ea6d34
Compare
6ea6d34 to
310ac1e
Compare
Contributor
|
Hello, You can consider making the switch disabled while the request is running ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
The enabled toggle doesn’t update after toggling enable/disable in the edit form and clicking Update.
Cause:
useState(source.IsEnabled)only initializes once, so it gets out of sync with server updates.The component used:
This initializes state only on first render, so when new server data arrives, checked does not update.
The previous useEffect workaround synced state after render but Introduced an extra render cycle
The solution is to remove local state and derive the value directly from mutation:
this shows optimistic toggle (
!source.IsEnabled) while mutation is pending and after success reflects updated server value amd on error reverts automatically to original valueNo extra renders are required with this aproach and no stale states. also keeps UI in sync with server.
AI & Automation Policy
AI/automation tools used (leave blank if none):
claude sonnet 4.6 helped in debuging and was used to review
Checklist