Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions arch/src/x86_64/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ use linux_loader::loader::elf::start_info::{
};
use log::{debug, error, info};
use serde::{Deserialize, Serialize};
pub use smbios::{SmbiosChassisConfig, SmbiosConfig, SmbiosSystem};
Comment thread
Coffeeri marked this conversation as resolved.
use thiserror::Error;
use vm_memory::{
Address, Bytes, GuestAddress, GuestAddressSpace, GuestMemory, GuestMemoryAtomic,
Expand Down Expand Up @@ -1101,18 +1102,15 @@ pub fn configure_system(
_num_cpus: u32,
setup_header: Option<setup_header>,
rsdp_addr: Option<GuestAddress>,
serial_number: Option<&str>,
uuid: Option<&str>,
oem_strings: Option<&[&str]>,
smbios: Option<&SmbiosConfig>,
topology: Option<(u16, u16, u16, u16)>,
) -> super::Result<()> {
// Write EBDA address to location where ACPICA expects to find it
guest_mem
.write_obj((layout::EBDA_START.0 >> 4) as u16, layout::EBDA_POINTER)
.map_err(Error::EbdaSetup)?;

let size = smbios::setup_smbios(guest_mem, serial_number, uuid, oem_strings)
.map_err(Error::SmbiosSetup)?;
let size = smbios::setup_smbios(guest_mem, smbios).map_err(Error::SmbiosSetup)?;

// Place the MP table after the SMIOS table aligned to 16 bytes
let offset = GuestAddress(layout::SMBIOS_START).unchecked_add(size);
Expand Down Expand Up @@ -1657,8 +1655,6 @@ mod unit_tests {
Some(layout::RSDP_POINTER),
None,
None,
None,
None,
);
config_err.unwrap_err();

Expand All @@ -1681,8 +1677,6 @@ mod unit_tests {
None,
None,
None,
None,
None,
)
.unwrap();

Expand Down Expand Up @@ -1710,8 +1704,6 @@ mod unit_tests {
None,
None,
None,
None,
None,
)
.unwrap();

Expand All @@ -1725,8 +1717,6 @@ mod unit_tests {
None,
None,
None,
None,
None,
)
.unwrap();
}
Expand Down
Loading
Loading