This repository was archived by the owner on Apr 28, 2026. It is now read-only.
tests: add SMBIOS coverage for modes sysinfo/host#152
Merged
Conversation
Coffeeri
force-pushed
the
feat/smbios
branch
2 times, most recently
from
ef2b82b to
915f5ce
Compare
phip1611
suggested changes
Feb 5, 2026
Member
phip1611
left a comment
phip1611
left a comment
There was a problem hiding this comment.
very nice first contribution to this repo :) Left a few remarks
Coffeeri
force-pushed
the
feat/smbios
branch
7 times, most recently
from
4f61d96 to
41f7052
Compare
Coffeeri
changed the title
phip1611
suggested changes
Feb 6, 2026
Member
phip1611
left a comment
phip1611
left a comment
There was a problem hiding this comment.
Nice work! :) left a few remarks
phip1611
reviewed
Feb 6, 2026
Coffeeri
force-pushed
the
feat/smbios
branch
6 times, most recently
from
3390454 to
c574850
Compare
hertrste
reviewed
Feb 9, 2026
Collaborator
|
Very nice tests! |
Coffeeri
force-pushed
the
feat/smbios
branch
5 times, most recently
from
33000d2 to
891c75e
Compare
phip1611
reviewed
Feb 9, 2026
hertrste
approved these changes
Feb 10, 2026
phip1611
approved these changes
Feb 10, 2026
Coffeeri
force-pushed
the
feat/smbios
branch
from
0c25c34 to
d98c63f
Compare
Add a test that verifies SMBIOS System Information fields provided via libvirt sysinfo configuration and exposed inside the guest. The test checks the expected system and partial chassis fields using `dmidecode` and additionally validates the chassis asset tag via sysfs. The test validates the following fields using `dmidecode -s`: - system-manufacturer - system-product-name - system-version - system-serial-number - system-uuid - system-sku-number - system-family - chassis-asset-tag The chassis asset tag is additionally verified via: /sys/devices/virtual/dmi/id/chassis_asset_tag On-behalf-of: SAP leander.kohler@sap.com Signed-off-by: Leander Kohler <leander.kohler@cyberus-technology.de>
In host mode, libvirt extracts SMBIOS data from the host using `dmidecode` and propagates it to Cloud Hypervisor via the --platform option. The UUID is not propagated automatically and must be explicitly defined in the libvirt XML configuration, as documented: copy all of Block 0 and Block 1, except for the UUID, from the host's SMBIOS values This commit adds a test that validates the expected SMBIOS fields when using smbios mode=host. On-behalf-of: SAP leander.kohler@sap.com Signed-off-by: Leander Kohler <leander.kohler@cyberus-technology.de>
This test checks the SMBBIOS Type 11 OEM Strings, which are overwritten using the nix generated libvirt XML. On-behalf-of: SAP leander.kohler@sap.com Signed-off-by: Leander Kohler <leander.kohler@cyberus-technology.de>
Coffeeri
force-pushed
the
feat/smbios
branch
from
d98c63f to
4348afc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds test coverage for SMBIOS handling in both libvirt SMBIOS modes:
sysinfoandhost.For
mode=sysinfo, the tests verify that SMBIOS System Information fieldsconfigured via libvirt XML are correctly exposed inside the guest. The
expected system and chassis fields are validated using
dmidecode, and thechassis asset tag is additionally checked via sysfs.
For
mode=host, the tests validate that SMBIOS data is correctly propagatedfrom the host to the guest using
dmidecode, and that the UUID handlingmatches the documented behavior (UUID must be explicitly defined in the
domain XML).
These tests improve coverage of SMBIOS behavior and help ensure consistent
exposure of system information across libvirt configurations.
Related PRs: