nix: use previous version of libvirt in version migration tests#196
Conversation
arctic-alpaca
force-pushed
the
libvirt-prev
branch
2 times, most recently
from
4e17510 to
88cf4a4
Compare
arctic-alpaca
force-pushed
the
libvirt-prev
branch
from
88cf4a4 to
434a22b
Compare
arctic-alpaca
force-pushed
the
libvirt-prev
branch
3 times, most recently
from
c5345fe to
fc4c9dd
Compare
There was a problem hiding this comment.
Great idea with the asserts!
I'm unsure if you also override the libvirt in the corresponding test suite.. something as you did here 0c55a77#diff-1cc580de297308d93d82f7b72446ae4b98832a8aae3378e9e134102519a0e33aR63
Please double-check!
PS: Apologies for the long review delay
arctic-alpaca
force-pushed
the
libvirt-prev
branch
2 times, most recently
from
01ddda2 to
fa7249b
Compare
The |
Oh I must have missed that during my review yesterday - thank you for pointing that out! |
arctic-alpaca
force-pushed
the
libvirt-prev
branch
from
fa7249b to
ebde57c
Compare
arctic-alpaca
force-pushed
the
libvirt-prev
branch
2 times, most recently
from
1848727 to
276140e
Compare
hertrste
left a comment
hertrste
left a comment
There was a problem hiding this comment.
I am happy with how this turned out now :)
arctic-alpaca
force-pushed
the
libvirt-prev
branch
from
c3b3000 to
39cc440
Compare
|
@amphi pointed out that it would be helpful to see the versions in CI to verify the expected behavior. (39cc440) Comparing the versions won't work for now since we reuse the same set of tests for the normal migration tests. |
arctic-alpaca
force-pushed
the
libvirt-prev
branch
from
39cc440 to
0de081e
Compare
arctic-alpaca
force-pushed
the
libvirt-prev
branch
from
0de081e to
32cadca
Compare
arctic-alpaca
force-pushed
the
libvirt-prev
branch
2 times, most recently
from
98a8a81 to
5776739
Compare
phip1611
left a comment
phip1611
left a comment
There was a problem hiding this comment.
I'm concerned this doesn't do the right thing (see my remarks). Please double-check. (In case I'm wrong, ignore all of the following)
You're definitely working here with a combination of Nix features that brings together some of the most complicated pieces, and the way we build our test suites only adds to that complexity.
- Nix Flakes
- Nix Overlays
- Multiple nixpkgs instantiations
- Passing parameters to functions that generate NixOS modules
- ...
That's not a very pleasant experience. Feel free to setup a meeting with StefanH, SebastianE or me to brain storm this again - this is for sure pretty complicated.
phip1611
left a comment
phip1611
left a comment
There was a problem hiding this comment.
Loos like its working from your data - very nice!
Allows overriding `libvirt` via overlay, which is necessary for the next commit. On-behalf-of: SAP julian.schindel@sap.com Signed-off-by: Julian Schindel <julian.schindel@cyberus-technology.de>
Since `libvirt` and `cloud-hypervisor` are shipped as a pair, the cross-version migration test should also use the appropriate `lbivirt` version. On-behalf-of: SAP julian.schindel@sap.com Signed-off-by: Julian Schindel <julian.schindel@cyberus-technology.de>
On-behalf-of: SAP julian.schindel@sap.com Signed-off-by: Julian Schindel <julian.schindel@cyberus-technology.de>
Allows verifying the versions of `libvirt` and `cloud-hypervisor` running in the respective VMs. Co-authored-by: Sebastian Eydam <sebastian.eydam@cyberus-technology.de> On-behalf-of: SAP julian.schindel@sap.com Signed-off-by: Julian Schindel <julian.schindel@cyberus-technology.de>
arctic-alpaca
force-pushed
the
libvirt-prev
branch
from
5776739 to
89e85f2
Compare
Adds support for `libvirt` in cross-version migration testing introduced in cyberus-technology/libvirt-tests#196. The change in `libvirt-tests` moved `libvirt` from a parameter to `pkgs`. This commit adapts the override to use the `libvirt` version from the repo to match the change. On-behalf-of: SAP julian.schindel@sap.com Signed-off-by: Julian Schindel <julian.schindel@cyberus-technology.de>
5 participants
Since
libvirtandcloud-hypervisorare shipped as pairs, the cross-version migration test should also use the appropriatelbivirtversion.Libvirt PR: https://gitlab.cyberus-technology.de/cyberus/cloud/libvirt/-/merge_requests/166