Skip to content

Add nullable instance health state & health_check delay field#164

Merged
mattoni merged 1 commit intomainfrom
mattoni/eng-1554-add-healthy-null-to-api-spec
Sep 13, 2023
Merged

Add nullable instance health state & health_check delay field#164
mattoni merged 1 commit intomainfrom
mattoni/eng-1554-add-healthy-null-to-api-spec

Conversation

@mattoni
Copy link
Member

@mattoni mattoni commented Sep 13, 2023

Adds new health check properties being implemented in the platform.

  • On an instance, state.health.healthy is now nullable, implying the first health check has not yet been performed
  • Added a delay field to the container deploy -> health_check config. This duration tells Cycle how long to wait before performing an initial health check (to give sufficient time for the container instance to start before falsely responding).
  • Corrects a mistake where instance state.health is actually nullable.

@mattoni mattoni self-assigned this Sep 13, 2023
Copy link
Collaborator

@aubuchcl aubuchcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems correct in structure and raised any questions that came up. Approved.

@mattoni mattoni merged commit aa424e1 into main Sep 13, 2023
@mattoni mattoni deleted the mattoni/eng-1554-add-healthy-null-to-api-spec branch September 13, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants