Add nullable instance health state & health_check delay field#164
Merged
Add nullable instance health state & health_check delay field#164
Conversation
aubuchcl
approved these changes
Sep 13, 2023
Collaborator
aubuchcl
left a comment
There was a problem hiding this comment.
This seems correct in structure and raised any questions that came up. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new health check properties being implemented in the platform.
state.health.healthyis now nullable, implying the first health check has not yet been performeddelayfield to the container deploy -> health_check config. This duration tells Cycle how long to wait before performing an initial health check (to give sufficient time for the container instance to start before falsely responding).state.healthis actually nullable.