Prepare cli for the versioning feature#399
Conversation
| @@ -1 +1 @@ | |||
| v6.4.1 | |||
| 0 | |||
There was a problem hiding this comment.
Invalid version here, put the version in the swagger.yml
There was a problem hiding this comment.
We don't have version yet. I think we'll update it after meta versioning is merged but before CLI is merged ?
There was a problem hiding this comment.
Don't merge yet, I will check with gael
internal/cyargs/stacks.go
Outdated
| cmd.Flags().String("stack-version-tag", "", "the stack version tag to use (e.g., v1.0.0)") | ||
| cmd.Flags().String("stack-version-branch", "", "the stack version branch to use (e.g., main)") | ||
| cmd.Flags().String("stack-version-commit-hash", "", "the stack version commit hash to use") |
There was a problem hiding this comment.
Make their name shorter, like:
--stack-tag
--stack-branch
--stack-commit-hash
I think shorter flags like:
--stack-tag -T
--stack-branch -B
--stack-commit-hash -H
Could work and not collide with other ones, try it, if it compiles it's good.
There was a problem hiding this comment.
I'm not a fan of these one letter flags, but the shorter versions look good
kerak19
force-pushed
the
lo-meta-versioning
branch
from
8ce720c to
c912207
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 62 out of 63 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kerak19
force-pushed
the
lo-meta-versioning
branch
from
c912207 to
9551c3b
Compare
|
The CI fails because CLI uses staging as a version of image. So it should pass after versioning is released on staging |
No description provided.