Skip to content

Fhacloid cli 107 refactor middleware to discard generated client#418

Merged
fhacloid merged 7 commits intodevelopfrom
fhacloid-cli-107-refactor-middleware-to-discard-generated-client
Mar 16, 2026
Merged

Fhacloid cli 107 refactor middleware to discard generated client#418
fhacloid merged 7 commits intodevelopfrom
fhacloid-cli-107-refactor-middleware-to-discard-generated-client

Conversation

@fhacloid
Copy link
Copy Markdown
Contributor

No description provided.

@fhacloid fhacloid self-assigned this Mar 14, 2026
@fhacloid fhacloid force-pushed the fhacloid-cli-107-refactor-middleware-to-discard-generated-client branch from 89a6ccb to 566bd4f Compare March 14, 2026 22:46
Copy link
Copy Markdown
Contributor Author

@fhacloid fhacloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cursoragent use a claude model, fix the comments, don't try to run anything as you don't have a configured environment yet. Ping me if you need more information.

Copy link
Copy Markdown
Contributor Author

@fhacloid fhacloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cursoragent fix all the comments.

@cursor
Copy link
Copy Markdown

cursor bot commented Mar 15, 2026

Use this as the GitHub reply:

Done — I fixed all review comments in the docs.

✅ Updated docs/adding-a-command.md:

  • Added idempotent middleware guidance (CreateOrUpdateX) and create/update detection flow
  • Clarified middleware file/category naming to match API docs tags
  • Added a dedicated section analyzing cmd/cycloid/teams subcommand structure and logic
  • Updated command guidance for:
    • get accepting identifiers via args and/or flag, with examples
    • multi-identifier get returning []*models.Widget
    • create/update idempotent behavior (create --update, update may create)
    • delete accepting args/flag, multiple values, returning deleted identifier(s)
  • Enforced explicit Args in command declarations (cobra.NoArgs etc.)
  • Updated flag examples so shared flags live in cyargs
  • Updated AddWidgetFlag example to use package-level widgetFlagName and return the flag name
  • Migrated examples from matryer/is to testify (assert/require)

✅ Updated docs/testing.md:

  • Switched backend startup from make be-start to make be-reset
  • Added note that be-reset is preferred to ensure a clean backend state
  • Updated related CY_API_URL note
  • Migrated test assertion examples to testify (assert/require)

Commit pushed: 6978761

Open in Web Open in Cursor 

@fhacloid fhacloid force-pushed the fhacloid-cli-107-refactor-middleware-to-discard-generated-client branch from 58a28f5 to c10d7fe Compare March 16, 2026 09:25
@locycloid locycloid requested a review from Copilot March 16, 2026 09:36
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the CLI middleware to discard the go-swagger generated client code, replacing it with a GenericRequest-based approach. Also adds documentation for LLM agents, architecture, and contributing guidelines.

Changes:

  • Removes entire go-swagger generated client packages (appearance, authentications, cloud_providers, code_generation, component_pipeline_resources, component_pipeline_resources_versions)
  • Adds CLAUDE.md, AGENTS.md, and updates CONTRIBUTING.md/DEVELOPING_TIPS.md with new architecture docs
  • Adds changelog entries for the refactor and new debug verbosity feature

Reviewed changes

Copilot reviewed 61 out of 1042 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
client/client/*/ (many files) Removed auto-generated go-swagger client/params/responses code
CLAUDE.md New LLM agent instructions for the codebase
AGENTS.md Mirror of CLAUDE.md for other LLM agents
CONTRIBUTING.md Rewritten to reference new docs
DEVELOPING_TIPS.md Added archive notice and typo fix
changelog/unreleased/*.yaml Changelog entries for refactor and debug feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

time: 2026-03-16T09:18:55.818866747Z
custom:
DETAILS: |
This is usefull to debug errors with the backend. Be warned that playload
@fhacloid fhacloid merged commit 8dd8d38 into develop Mar 16, 2026
1 check passed
@fhacloid fhacloid deleted the fhacloid-cli-107-refactor-middleware-to-discard-generated-client branch March 16, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants