fix(ctrl): removed redis connection#223
Merged
petar-cvit merged 7 commits intocyclops-ui:mainfrom Apr 24, 2024
hanshal101:remove-redis-conn
Merged
fix(ctrl): removed redis connection#223petar-cvit merged 7 commits intocyclops-ui:mainfrom hanshal101:remove-redis-conn
petar-cvit merged 7 commits intocyclops-ui:mainfrom
hanshal101:remove-redis-conn
Conversation
petar-cvit
requested changes
Apr 22, 2024
Contributor
Author
|
Here you go. |
petar-cvit
requested changes
Apr 23, 2024
Collaborator
petar-cvit
left a comment
petar-cvit
left a comment
There was a problem hiding this comment.
You will also need to delete this folder, which implements templates.Storage and all occurrences of it.
It's the old way of storing templates, so we can get rid of it. I believe there are still some endpoints using that struct. You can delete those as well
Contributor
Author
|
yup I actually thought of removing this qt first and then resolve all the errors. But I thought this folder might have some exports in other part of the code base. Well will do👍 |
petar-cvit
requested changes
Apr 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #195
Closes #195
Description
This PR removes the Redis Connection in the
cyclops-ctrl.First (after depreciation) we could see the redis connection error in the console. But after this PR you wont