Skip to content

ft(cyctl): Implementation of describe command for the custom resources#292

Merged
petar-cvit merged 14 commits intocyclops-ui:mainfrom
siddhantprateek:describe-cyctl
May 25, 2024
Merged

ft(cyctl): Implementation of describe command for the custom resources#292
petar-cvit merged 14 commits intocyclops-ui:mainfrom
siddhantprateek:describe-cyctl

Conversation

@siddhantprateek
Copy link
Contributor

closes #291

📑 Description

✅ Checks

  • I have updated the documentation as required
  • I have performed a self-review of my code

ℹ Preview

describe.mp4

@siddhantprateek siddhantprateek requested a review from a team as a code owner May 23, 2024 09:55
@siddhantprateek
Copy link
Contributor Author

@petar-cvit I just saw your message on the issue, is the values part in yaml be fine?

$ cyctl describe modules nginx-deployment


Name:         nginx-deployment
Namespace:    cyclops
Labels:       environment=local
              k8slens-edit-resource-version=v1alpha1
Annotations:  cluster=local
              kubernetes=minikube

Creation:  2024-05-22 22:09:25 +0530 IST


Status:  succeeded

Template:
 Repository:     https://github.com/cyclops-ui/templates
 Relative Path:  demo-extended
 Branch:         main

Values:
  general:
    environment:
      ENVIRONMENT: production
    image: nginx
    version: 1.14.2
  name: nginx-app
  networking:
    expose: true
    port: 8080
  scaling:
    replicas: 2
    resources:
      cpu: 0.1
      memory: 0.01

-------------------------------

@petar-cvit
Copy link
Collaborator

This is even better 😄

Copy link
Collaborator

@petar-cvit petar-cvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove all the empty lines? I think its no going to affect readability since kubectl describe doesn't print empty lines
Screenshot 2024-05-23 at 14 17 23

Copy link
Collaborator

@petar-cvit petar-cvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @siddhantprateek

@petar-cvit petar-cvit merged commit 0e68c2c into cyclops-ui:main May 25, 2024
@siddhantprateek
Copy link
Contributor Author

Great job @siddhantprateek

Thank you for taking the time to review it 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cyctl: Implement a describe method for Modules / TemplateStore / TemplateAuthRules

2 participants