CM-30407 - Use CLI in onedir mode on macOS #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-fedorov
approved these changes
Jan 16, 2024
MarshalX
deleted the
CM-30407-add-support-of-onedir-cli-to-jet-brains-plugin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr performance fix of macOS
we are using onedir mode (pyinstaller) on macOS because of the gatekeeper that verifies the executable each run which is the reason for the long cold start (up to 12 seconds)
also, it brings support of macOS ARM CLI
we can't merge it because of issues with multiprocessing in packaged CLICLI has been fixed
More info about performance issues of onefile mode on macOS: https://github.com/orgs/pyinstaller/discussions/8167