Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cartfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ github "gilesvangruisen/Swift-YouTube-Player"
github "Alamofire/AlamofireImage" ~> 3.3
github "xmartlabs/XLPagerTabStrip" ~> 8.0
github "malcommac/ScrollingStackContainer" ~> 0.5
github "youtube/youtube-ios-player-helper"
1 change: 1 addition & 0 deletions Cartfile.resolved
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ github "danielrhodes/Swift-ActionCableClient" "v0.2.3"
github "gilesvangruisen/Swift-YouTube-Player" "v0.4.0"
github "malcommac/ScrollingStackContainer" "0.5.0"
github "xmartlabs/XLPagerTabStrip" "8.0.1"
github "youtube/youtube-ios-player-helper" "0.1.6"
6 changes: 6 additions & 0 deletions Carthage/Checkouts/youtube-ios-player-helper/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# iOS
.DS_Store
Pods/
Podfile.lock
xcuserdata/
*.xcworkspace/
19 changes: 19 additions & 0 deletions Carthage/Checkouts/youtube-ios-player-helper/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Copyright 2014 Google Inc. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# YouTube-Player-iOS-Helper CHANGELOG

## 0.1.0

Initial release.
59 changes: 59 additions & 0 deletions Carthage/Checkouts/youtube-ios-player-helper/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
# How to contribute #

We'd love to accept your patches and contributions to this project. There are
a just a few small guidelines you need to follow.


## Contributor License Agreement ##

Contributions to any Google project must be accompanied by a Contributor
License Agreement. This is not a copyright **assignment**, it simply gives
Google permission to use and redistribute your contributions as part of the
project.

* If you are an individual writing original source code and you're sure you
own the intellectual property, then you'll need to sign an [individual
CLA][].

* If you work for a company that wants to allow you to contribute your work,
then you'll need to sign a [corporate CLA][].

You generally only need to submit a CLA once, so if you've already submitted
one (even if it was for a different project), you probably don't need to do it
again.

[individual CLA]: https://developers.google.com/open-source/cla/individual
[corporate CLA]: https://developers.google.com/open-source/cla/corporate


## Submitting a patch ##

1. It's generally best to start by opening a new issue describing the bug or
feature you're intending to fix. Even if you think it's relatively minor,
it's helpful to know what people are working on. Mention in the initial
issue that you are planning to work on that bug or feature so that it can
be assigned to you.

1. Follow the normal process of [forking][] the project, and setup a new
branch to work in. It's important that each group of changes be done in
separate branches in order to ensure that a pull request only includes the
commits related to that bug or feature.

1. Test your code on a device if you can. There are a bunch of edge conditions
that can be triggered in `UIWebView` where behavior in the simulator is
going to differ from behavior on a physical device.

1. Any significant changes should almost always be accompanied by tests. The
project already has good test coverage, so look at some of the existing
tests if you're unsure how to go about it.

1. Do your best to have [well-formed commit messages][] for each change.
This provides consistency throughout the project, and ensures that commit
messages are able to be formatted properly by various git tools.

1. Finally, push the commits to your fork and submit a [pull request][].

[forking]: https://help.github.com/articles/fork-a-repo
[well-formed commit messages]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
[squash]: http://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits
[pull request]: https://help.github.com/articles/creating-a-pull-request
Loading