Skip to content

cylc-7 and cylc-8 download buttons#35

Merged
hjoliver merged 5 commits into
cylc:masterfrom
hjoliver:download-button
Sep 28, 2019
Merged

cylc-7 and cylc-8 download buttons#35
hjoliver merged 5 commits into
cylc:masterfrom
hjoliver:download-button

Conversation

@hjoliver
Copy link
Copy Markdown
Member

Close #34

  • two download buttons that clearly indicate "production" or "preview" use
  • (removes the automatically updating list of multiple latest releases ... it was kind of cool, but used up screen real estate and no one really needs it).
  • (also gratitiously tidied some front page text a bit)

Thought I'd better get this done before going home, in the interests of minimizing user confusion, since @sadielbartholomew raised #30 .

@kinow - my JS may be a bit ropey, but it seems to work https://hjoliver.github.io/cylc.github.io/

One review should do.

@hjoliver hjoliver requested a review from kinow September 27, 2019 06:13
@hjoliver hjoliver self-assigned this Sep 27, 2019
Copy link
Copy Markdown
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

image

Nit-picking on the tabs vs. spaces (again hehe), but pre-approved, as this is not a blocker IMO.

Comment thread _includes/repository.html Outdated
Comment thread _includes/progress.html
Copy link
Copy Markdown
Contributor

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestion. Feel free to ignore or postpone. Does what it says otherwise.

Comment thread _includes/progress.html
Copy link
Copy Markdown
Collaborator

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (builds &) looks great & as described, plus it's a nice touch that the user sites logo set links through to the users page. Having:

two download buttons that clearly indicate "production" or "preview" use

seems like a very good solution to the current scenario regarding expected/future releases.

One review should do.

.. but have three 😄

(I'm not going to merge since Matt has raised a very good suggestion, so I'll approve & leave you to decide whether you would like to address that & if so, in this PR. Please merge when you see fit.)

@hjoliver hjoliver merged commit 8eef57c into cylc:master Sep 28, 2019
@hjoliver hjoliver deleted the download-button branch September 28, 2019 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need separate download buttons for 8.0a1 and 7.8.x

4 participants