cylc-7 and cylc-8 download buttons#35
Merged
Merged
Conversation
kinow
approved these changes
Sep 27, 2019
hjoliver
commented
Sep 27, 2019
kinow
approved these changes
Sep 27, 2019
matthewrmshin
approved these changes
Sep 27, 2019
Contributor
matthewrmshin
left a comment
There was a problem hiding this comment.
Some suggestion. Feel free to ignore or postpone. Does what it says otherwise.
sadielbartholomew
approved these changes
Sep 27, 2019
Collaborator
sadielbartholomew
left a comment
There was a problem hiding this comment.
This (builds &) looks great & as described, plus it's a nice touch that the user sites logo set links through to the users page. Having:
two download buttons that clearly indicate "production" or "preview" use
seems like a very good solution to the current scenario regarding expected/future releases.
One review should do.
.. but have three 😄
(I'm not going to merge since Matt has raised a very good suggestion, so I'll approve & leave you to decide whether you would like to address that & if so, in this PR. Please merge when you see fit.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Close #34
Thought I'd better get this done before going home, in the interests of minimizing user confusion, since @sadielbartholomew raised #30 .
@kinow - my JS may be a bit ropey, but it seems to work https://hjoliver.github.io/cylc.github.io/
One review should do.