install-cylc-components: respect login shell#100
Merged
Conversation
This was referenced Mar 4, 2025
MetRonnie
requested changes
Mar 5, 2025
Member
There was a problem hiding this comment.
I think we should use bash -elo pipefail {0}? https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#defaultsrunshell
oliver-sanders
commented
Mar 5, 2025
oliver-sanders
commented
Mar 5, 2025
Member
Author
There was a problem hiding this comment.
Hmmm. The action is running fine, but errors are appearing downstream (which doesn't make sense).
Can see some set -u error coming from profile.d stuff (which we have no control over), will try without 🤷 .
That seems to have worked: https://github.com/oliver-sanders/cylc-rose/actions/runs/13674608714/job/38232630689?pr=5
MetRonnie
approved these changes
Mar 5, 2025
Member
|
Actually would it be worth adding a test for this to? release-actions/.github/workflows/test.yml Lines 1 to 3 in 04781c7 |
oliver-sanders
force-pushed
the
login-shell
branch
from
4c24efe to
d79bb6c
Compare
oliver-sanders
force-pushed
the
login-shell
branch
from
d79bb6c to
2f16a6c
Compare
Member
Author
|
@MetRonnie, added a simple test. |
MetRonnie
reviewed
Mar 7, 2025
oliver-sanders
force-pushed
the
login-shell
branch
from
a85bdfb to
8891060
Compare
MetRonnie
requested changes
Mar 10, 2025
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
MetRonnie
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a Bash login shell.
This opens up working with Micromamba managed environments.
Checklist
README.mdand have opened this against the correct branch & milestone