Windows mwebd build script changes#1325
Merged
julian-CStack merged 11 commits intostagingfrom May 5, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## staging #1325 +/- ##
===========================================
- Coverage 4.86% 4.84% -0.02%
===========================================
Files 1050 1051 +1
Lines 107145 107437 +292
===========================================
- Hits 5208 5207 -1
- Misses 101937 102230 +293 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… this automatically), and falls back to the existing WSL cross-compile path for local Windows devs. Non-Windows hosts are unchanged.
danrmiller
changed the title
The Linux CI step ran flutter build linux --release without first building the local jsoncpp/libsecret artifacts that linux/CMakeLists.txt hardcoded, so ninja failed looking for scripts/linux/build/jsoncpp/.../libjsoncpp.so. Add a USE_SYSTEM_SECURE_STORAGE_DEPS switch to the Linux CMakeLists template: when set (or the same-named env var is "1"), link against the pkg-config-resolved system jsoncpp and libsecret-1 and bundle the .so files from their reported libdir; otherwise keep the existing local-build path used by scripts/linux/build_all.sh. Set USE_SYSTEM_SECURE_STORAGE_DEPS=1 on the build-linux job, where the stackwallet-ci image already provides libjsoncpp-dev and libsecret-1-dev.
AGP rejects ndk.abiFilters alongside the abi splits config that `flutter build apk --split-per-abi` enables. Drop the explicit filter in the Android build.gradle template; Flutter's default android-arm, android-arm64, android-x64 set is what we want anyway, and the CI's APK-renaming step already references those ABI names.
Brings in the openssl + openssl-sys MSRV pins for rustc 1.71.
julian-CStack
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Platform.script.toFilePath() instead of manually stripping the leading slash until "C:" is found, so the build works when the repo is checked out on any drive.