v2.1.1

[cyring]

See change-log in the release

---

This discussion was created from the release v2.1.1.

[bubbleguuum]

Impressive update, congrats !

Already updated packages for openSUSE, including submission to Tumbleweed and for the first time ppc64le packages:

https://build.opensuse.org/package/show/hardware/CoreFreq

There's an oddity with a kernel macro causing a failure on Leap 16.0 x86_64. Wonder if it is a problem of the gcc 13 version (13.4.0+git9739-160000) bundled with that distro:

[   22s] # CC [M]  /home/abuild/rpmbuild/BUILD/CoreFreq-2.1.1-build/CoreFreq-2.1.1/build/module/corefreqk.o
[   22s]   gcc-13 -Wp,-MMD,/home/abuild/rpmbuild/BUILD/CoreFreq-2.1.1-build/CoreFreq-2.1.1/build/module/.corefreqk.o.d -nostdinc -I/usr/src/linux-6.12.0-160000.32/arch/x86/include -I./arch/x86/include/generated -I/usr/src/linux-6.12.0-160000.32/include -I./include -I/usr/src/linux-6.12.0-160000.32/arch/x86/include/uapi -I./arch/x86/include/generated/uapi -I/usr/src/linux-6.12.0-160000.32/include/uapi -I./include/generated/uapi -include /usr/src/linux-6.12.0-160000.32/include/linux/compiler-version.h -include /usr/src/linux-6.12.0-160000.32/include/linux/kconfig.h -include /usr/src/linux-6.12.0-160000.32/include/linux/compiler_types.h -D__KERNEL__ -fmacro-prefix-map=/usr/src/linux-6.12.0-160000.32/= -std=gnu11 -fshort-wchar -funsigned-char -fno-common -fno-PIE -fno-strict-aliasing -mno-sse -mno-mmx -mno-sse2 -mno-3dnow -mno-avx -fcf-protection=branch -fno-jump-tables -m64 -falign-jumps=1 -falign-loops=1 -mno-80387 -mno-fp-ret-in-387 -mpreferred-stack-boundary=3 -mskip-rax-setup -mtune=generic -mno-red-zone -mcmodel=kernel -Wno-sign-compare -fno-asynchronous-unwind-tables -mindirect-branch=thunk-extern -mindirect-branch-register -mindirect-branch-cs-prefix -mfunction-return=thunk-extern -fno-jump-tables -mharden-sls=all -fpatchable-function-entry=16,16 -fno-delete-null-pointer-checks -O2 -fno-allow-store-data-races -fstack-protector-strong -fno-stack-clash-protection -pg -mrecord-mcount -mfentry -DCC_USING_FENTRY -flive-patching=inline-clone -fmin-function-alignment=16 -fstrict-flex-arrays=3 -fno-strict-overflow -fno-stack-check -fconserve-stack -Wall -Wundef -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Werror=strict-prototypes -Wno-format-security -Wno-trigraphs -Wno-frame-address -Wno-address-of-packed-member -Wmissing-declarations -Wmissing-prototypes -Wframe-larger-than=2048 -Wno-main -Wno-dangling-pointer -Wvla -Wno-pointer-sign -Wcast-function-type -Wno-stringop-overflow -Wno-array-bounds -Wno-alloc-size-larger-than -Wimplicit-fallthrough=5 -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -Wenum-conversion -Wextra -Wunused -Wno-unused-but-set-variable -Wno-unused-const-variable -Wno-packed-not-aligned -Wno-format-overflow -Wno-format-truncation -Wno-stringop-truncation -Wno-override-init -Wno-missing-field-initializers -Wno-type-limits -Wno-shift-negative-value -Wno-maybe-uninitialized -Wno-sign-compare -Wno-unused-parameter -g -gdwarf-5 -I/home/abuild/rpmbuild/BUILD/CoreFreq-2.1.1-build/CoreFreq-2.1.1/x86_64 -D COREFREQ_MAJOR=2 -D COREFREQ_MINOR=1 -D COREFREQ_REV=1 -D CORE_COUNT=256 -D TASK_ORDER=5 -D MAX_FREQ_HZ=7125000000 -Wall -Wfatal-errors -D DELAY_TSC=1 -D MSR_CORE_PERF_UCC=MSR_IA32_APERF -D MSR_CORE_PERF_URC=MSR_IA32_MPERF -D DT_VIRTUAL_BOARD='{ "linux,dummy-virt", "riscv-virtio", "qemu,pseries", NULL }'  -DMODULE  -DKBUILD_BASENAME='"corefreqk"' -DKBUILD_MODNAME='"corefreqk"' -D__KBUILD_MODNAME=kmod_corefreqk -c -o /home/abuild/rpmbuild/BUILD/CoreFreq-2.1.1-build/CoreFreq-2.1.1/build/module/corefreqk.o /home/abuild/rpmbuild/BUILD/CoreFreq-2.1.1-build/CoreFreq-2.1.1/build/module/corefreqk.c  
[   22s] In file included from /usr/src/linux-6.12.0-160000.32/include/linux/objtool.h:9,
[   22s]                  from /usr/src/linux-6.12.0-160000.32/arch/x86/include/asm/alternative.h:7,
[   22s]                  from /usr/src/linux-6.12.0-160000.32/arch/x86/include/asm/barrier.h:5,
[   22s]                  from /usr/src/linux-6.12.0-160000.32/include/linux/list.h:11,
[   22s]                  from /usr/src/linux-6.12.0-160000.32/include/linux/module.h:12,
[   22s]                  from /home/abuild/rpmbuild/BUILD/CoreFreq-2.1.1-build/CoreFreq-2.1.1/build/module/corefreqk.c:26:
[   22s] /usr/src/linux-6.12.0-160000.32/arch/x86/include/asm/asm.h:12:41: error: expected identifier or ‘(’ before string constant
[   22s]    12 | # define __ASM_FORM(x, ...)             " " __stringify(x,##__VA_ARGS__) " "
[   22s]       |                                         ^~~
[   22s] /usr/src/linux-6.12.0-160000.32/arch/x86/include/asm/asm.h:18:33: note: in expansion of macro ‘__ASM_FORM’
[   22s]    18 | #define _ASM_BYTES(x, ...)      __ASM_FORM(.byte x,##__VA_ARGS__ ;)
[   22s]       |                                 ^~~~~~~~~~
[   22s] /usr/src/linux-6.12.0-160000.32/arch/x86/include/asm/msr.h:303:17: note: in expansion of macro ‘_ASM_BYTES’
[   22s]   303 | #define WRMSRNS _ASM_BYTES(0x0f,0x01,0xc6)
[   22s]       |                 ^~~~~~~~~~
[   22s] /home/abuild/rpmbuild/BUILD/CoreFreq-2.1.1-build/CoreFreq-2.1.1/x86_64/coretypes.h:1490:17: note: in expansion of macro ‘WRMSRNS’
[   22s]  1490 |                 WRMSRNS         : 20-19, /* Sierra Forest, Grand Ridge  */
[   22s]       |                 ^~~~~~~
[   22s] compilation terminated due to -Wfatal-errors.
[   22s] make[3]: *** [/usr/src/linux-6.12.0-160000.32/scripts/Makefile.build:229: /home/abuild/rpmbuild/BUILD/CoreFreq-2.1.1-build/CoreFreq-2.1.1/build/module/corefreqk.o] Error 1
[   22s] make[2]: *** [/usr/src/linux-6.12.0-160000.32/Makefile:1971: /home/abuild/rpmbuild/BUILD/CoreFreq-2.1.1-build/CoreFreq-2.1.1/build] Error 2
[   22s] make[1]: *** [../../../linux-6.12.0-160000.32/Makefile:224: __sub-make] Error 2
[   22s] make: *** [Makefile:181: build/corefreqk.ko] Error 2
[   22s] make: *** Waiting for unfinished jobs....
[   22s] cc  -Wall -Wfatal-errors -D COREFREQ_MAJOR=2 -D COREFREQ_MINOR=1 -D COREFREQ_REV=1 -D CORE_COUNT=256 -D TASK_ORDER=5 -D MAX_FREQ_HZ=7125000000 -D UBENCH=0 -D DELAY_TSC=1  \
[   22s]   -c x86_64/corefreq-cli.c -o build/corefreq-cli.o
[   22s] error: Bad exit status from /var/tmp/rpm-tmp.P3E1KC (%build)

Is clang supported as compiler ? If so I could force it on Leap 16.0.

[cyring]

Thank you.
meanwhile I have reformatted the change log

---

I'm currently building against version 16

gcc --version
gcc (GCC) 16.1.1 20260430

uname -r
7.0.9-arch1-1

and I'm also building fine with my oldest VM CentOS

probably there is a mix among CoreFreq source codes in your workspace

make sure to clean before rebuild
or try to clone the repository from scratch again

---

clang

make clean
make CC='clang'

it works if the running kernel is also built with the same clang.
if using gcc then module won't build and stops with such error

  MD [build]
  MD [build/module]
  CC [build/corefreqd.o]
  LN [build/Makefile]
  CC [build/corefreqm.o]
  LN [build/module/corefreqk.c]
  CC [build/corefreq-cli.o]
  CC [build/corefreq-ui.o]
  CC [build/corefreq-cli-rsc.o]
  CC [build/corefreq-cli-json.o]
  CC [build/corefreq-cli-extra.o]
  LD [build/corefreqd]
warning: the compiler differs from the one used to build the kernel
  The kernel was built by: gcc (GCC) 16.1.1 20260430
  You are using:           clang version 22.1.5
  CC [M]  module/corefreqk.o
clang: fatal error: unknown argument: '-mpreferred-stack-boundary=3'

[bubbleguuum]

Each build on OBS is automated in a sandbox corresponding to the distro, thus always clean.
Default compiler on Leap 16.0 is gcc13.

abuild@p72:~> gcc --version
gcc (SUSE Linux) 13.4.0

Not even Tumbleweed uses gcc 16 as default yet (it is using 15 currently), although it will soon.

Anyway, this is a quirk of this gcc version on Leap 16. It is heavily patched so who knows if some patch did not break something.
No issue on (upcoming) Leap 16.1, older openSUSE versions and of course Tumbleweed.

[cyring]

How can I reproduce this environment ?

[bubbleguuum]

Before v2.1.1, this patch was needed for compilation to work on Leap 16.0 due to the heavily patched kernel, with patches backported from more recent versions.
This patch is not necessary anymore (at least it fails to apply), but I wonder if the compilation error in kernel headers is not just the consequence of some unrelated prior error due to the frankenstein kernel.

[bubbleguuum]

You need the osc cli tool installed (probably easier on openSUSE but likely packaged in other distros).
It is the tool used to interact with OBS (Open Build Service).

Then clone the devel project:

osc -A https://api.opensuse.org checkout hardware/CoreFreq && cd $_

compile it (+ generate RPM if it compiles) locally for Leap 16.0 in a sandbox:

osc build 16.0 x86_64

to inspect the sandbox:

osc shell

[cyring]

That will be long for me to fix it
My suse VM is gcc 14 and I need to create a VM the way it fails

[cyring]

Issue solved in #594