Export single-cells command and splits. #280
Merged
Arkkienkeli merged 5 commits intotf2from Oct 6, 2021
Merged
Conversation
jccaicedo
requested changes
Sep 29, 2021
Member
jccaicedo
left a comment
There was a problem hiding this comment.
- Removing sampling of single cells: change the name of the command => export_single_cells and the associated messages
- Change "single_cell_sample" for "single_cell_set"
- Change the if statements for naming the metadata files for initialization in the cli main function.
- Prioritize making TRAINv1 work.
- Can we parameterize augmentation?
7bfddcb to
81cfd28
Compare
81cfd28 to
3c9d7ee
Compare
Member
Author
|
This comment will be addressed in another PR:
Changes:
|
…ke consistent to sample_crop_generator mode.
jccaicedo
approved these changes
Oct 6, 2021
Member
jccaicedo
left a comment
There was a problem hiding this comment.
It looks good to me!
Thank you for cleaning the code and keeping naming conventions consistent.
This was referenced Oct 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is going to be a pull-request with some updates to training strategies, sampling, augmentations.