Skip to content

Export single-cells command and splits. #280

Merged
Arkkienkeli merged 5 commits intotf2from
training_merge
Oct 6, 2021
Merged

Export single-cells command and splits. #280
Arkkienkeli merged 5 commits intotf2from
training_merge

Conversation

@Arkkienkeli
Copy link
Copy Markdown
Member

This is going to be a pull-request with some updates to training strategies, sampling, augmentations.

Copy link
Copy Markdown
Member

@jccaicedo jccaicedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Removing sampling of single cells: change the name of the command => export_single_cells and the associated messages
  • Change "single_cell_sample" for "single_cell_set"
  • Change the if statements for naming the metadata files for initialization in the cli main function.
  • Prioritize making TRAINv1 work.
  • Can we parameterize augmentation?

@Arkkienkeli
Copy link
Copy Markdown
Member Author

Arkkienkeli commented Oct 6, 2021

This comment will be addressed in another PR:

  • Can we parameterize augmentation?

Changes:

  1. The command to export single cells: export-sc
  2. training_values and validation_values have become training and validation to make it consistent with sample_crop_generator modes.
  3. The single-cell metadata now has target and split columns as in the main metadata.
  4. The option --sample is now --single-cells
  5. . single_cell_sample --> single_cell_set in __main.py__
  6. Conditions in __main__.py changed.

This should close issues #278 and #275

@Arkkienkeli Arkkienkeli changed the title Training strategies merge + augmentations Export single-cells changes Oct 6, 2021
@Arkkienkeli Arkkienkeli requested a review from jccaicedo October 6, 2021 13:02
@Arkkienkeli Arkkienkeli changed the title Export single-cells changes Export single-cells command and splits. Oct 6, 2021
Copy link
Copy Markdown
Member

@jccaicedo jccaicedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!
Thank you for cleaning the code and keeping naming conventions consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants