Skip to content

Update online labeling crop generator. #291

Merged
Arkkienkeli merged 4 commits intotf2from
issue/290
Oct 12, 2021
Merged

Update online labeling crop generator. #291
Arkkienkeli merged 4 commits intotf2from
issue/290

Conversation

@Arkkienkeli
Copy link
Copy Markdown
Member

@Arkkienkeli Arkkienkeli commented Oct 8, 2021

Make online_labels_cropgen.py consistent with the latest changes.
The LAMBDA and online_label_smoothing are parameterized in the config.
Closes #290

@Arkkienkeli Arkkienkeli requested a review from jccaicedo October 8, 2021 09:39
@Arkkienkeli Arkkienkeli self-assigned this Oct 8, 2021
@Arkkienkeli Arkkienkeli linked an issue Oct 8, 2021 that may be closed by this pull request
Copy link
Copy Markdown
Member

@jccaicedo jccaicedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove distinction between training and validation for randomizing data (around line 75).
Unify the LABEL_SMOOTHING parameter with the parameter in the Keras loss function (automatically set to zero when using this crop generator).

@Arkkienkeli Arkkienkeli requested a review from jccaicedo October 12, 2021 07:34
Copy link
Copy Markdown
Member

@jccaicedo jccaicedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jccaicedo
Copy link
Copy Markdown
Member

Thanks for the PR, @Arkkienkeli !

@Arkkienkeli Arkkienkeli merged commit 4e48082 into tf2 Oct 12, 2021
@Arkkienkeli Arkkienkeli deleted the issue/290 branch October 12, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update online labels crop generator.

2 participants