Fix silent_thread_map passing invalid 'leave' kwarg #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utor The `leave` parameter is tqdm-specific and was being passed through to `ThreadPoolExecutor.map()` which doesn't accept it, causing a TypeError when `mean_average_precision` was called with `progress_bar=False`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
3 tasks
Instead of filtering out tqdm-specific kwargs in silent_thread_map, address the root cause by only passing leave=False when using tqdm's thread_map. This is cleaner as each function only receives arguments it understands. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TypeErrorwhen callingmean_average_precisionwithprogress_bar=Falseleavekwarg (tqdm-specific) was being passed toThreadPoolExecutor.map()which doesn't accept itTest plan
uv run pytestpasses (62 tests)uv run ruff check src/ tests/passes🤖 Generated with Claude Code