Only present vhosts what have htdocs, example of override disabling a service#497
Only present vhosts what have htdocs, example of override disabling a service#497keithy wants to merge 4 commits into
Conversation
| if ($handle = opendir($docRoot)) { | ||
| while (false !== ($directory = readdir($handle))) { | ||
| if ($this->_is_valid_dir($docRoot . DIRECTORY_SEPARATOR . $directory) && $directory != '.' && $directory != '..') { | ||
| if ($this->_is_valid_dir($docRoot . DIRECTORY_SEPARATOR . $directory. "/". $htdocs) && $directory != '.' && $directory != '..') { |
There was a problem hiding this comment.
This will make a big difference and should be discussed with the community.
Current behaviour:
- Project exists, but does not have a vhost: Intranet will actually complain and let you know where to create the
htdocsdirectory.
New behaviour:
- Project exists, but does not have a vhost: Intranet will not show this vhost.
The current behaviour is helping people a lot to get started with the Devilbox. The new one will counteract this, but will allow more advanced people to hide stuff they intentionally want to hide.
|
I didnt consider your use case fully. |
|
@keithy that's a good idea I didn't even think about yet. What do you think about having that setting in |
|
Hi, that works for me! My use case was this... I discovered that the site I was working on was using include_path and had libraries in Then I started developing and used composers "path" repositories which are symlinked into the projects. Again the only sensible place to put shared resources was in that top directory. So... your UI_IGNORE idea would do the trick. AND you could make it a wildcard. |
|
Wildcard is even better 👍 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@keithy I will close this PR as it is almost 10 month old with no further commits. |
FEATURE_NAME
Goal
DESCRIPTION