Conversation
…ke checks Co-authored-by: d-oit <6849456+d-oit@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Corrected hallucinated GitHub Action versions and Node.js version in workflows. - Standardized on Node.js 22 and v4 of core actions (checkout, setup-node, pnpm/action-setup, upload-artifact) pinned to valid SHAs. - Extended standard verification gate (`pnpm verify`) to include coverage enforcement and smoke E2E tests. - Updated `scripts/quality_gate.sh` for local parity with CI. - Defined and enforced coverage thresholds across all packages. - Configured CI `smoke-e2e` job to run after `build`. - Updated `AGENTS.md` with new quality standards. Co-authored-by: d-oit <6849456+d-oit@users.noreply.github.com>
- Extended `pnpm verify` and `scripts/quality_gate.sh` to include `test:coverage`, `build`, and `test:e2e:smoke`. - Enforced coverage thresholds in all packages: - web: 40% Lines, 30% Functions - worker: 55% Lines, 50% Functions - shared: 25% Lines, 5% Functions - reader-core: 75% Lines, 70% Functions - Added `smoke-e2e` job to CI workflow and updated `test` job to use coverage. - Restored and validated correct 2026 environment versions (Node.js 24, v6/v7 core actions with pinned SHAs). - Updated `AGENTS.md` to reflect new quality gate standards. Co-authored-by: d-oit <6849456+d-oit@users.noreply.github.com>
1 participant
Extended the project quality gate by incorporating coverage enforcement and smoke E2E tests into the canonical verification paths.
Key changes:
package.jsonverifyscript to:pnpm lint && pnpm typecheck && pnpm test:coverage && pnpm build && pnpm test:e2e:smoke.scripts/quality_gate.shto include the same coverage and smoke test steps for local pre-commit parity.vitest.config.tsfor@do-epub-studio/web,@do-epub-studio/worker,@do-epub-studio/shared, and@do-epub-studio/reader-core..github/workflows/ci.ymlby adding asmoke-e2ejob that runs after thebuildjob, and updated thetestjob to usetest:coverage.AGENTS.mdto document the new coverage thresholds as blocking requirements.Fixes #99
PR created automatically by Jules for task 9464927846600478541 started by @d-oit