feat: add per-key locking to MemoryStore and LocalStore set_range#178
Merged
d-v-b merged 1 commit intoMay 31, 2026
Merged
Conversation
MemoryStore uses per-key asyncio.Lock / threading.Lock to serialise concurrent set_range / set_range_sync calls on the same key. LocalStore uses a double-checked file-lock protocol: the target file is atomically renamed to a key.__lock__ sibling (via _safe_move) to signal exclusive ownership across both threads and processes, with stale-lock recovery after 60 s. The in-process asyncio.Lock / threading.Lock guards the rename so only one coroutine/thread races to the filesystem at a time. Concurrent tests are added for both stores verifying that parallel writes to non-overlapping byte ranges produce the correct combined result. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MemoryStore uses per-key asyncio.Lock / threading.Lock to serialise concurrent set_range / set_range_sync calls on the same key.
LocalStore uses a double-checked file-lock protocol: the target file is atomically renamed to a key.lock sibling (via _safe_move) to signal exclusive ownership across both threads and processes, with stale-lock recovery after 60 s. The in-process asyncio.Lock / threading.Lock guards the rename so only one coroutine/thread races to the filesystem at a time.
Concurrent tests are added for both stores verifying that parallel writes to non-overlapping byte ranges produce the correct combined result.
TODO:
docs/user-guide/*.mdchanges/