fix(local): reject logical paths containing "." or ".." segments#758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #755.
仮想ファイルツリーで
POST /api/content/createやPOST /api/contentの論理パス（data.pathおよびfrontMatter[pathKey]）に../.セグメントや NUL バイトが含まれていると、resolver にそのまま登録されてしまい、ブラウザがリンクを正規化したあとtoDiskPathで見つからず、ファイルが「保存できたが UI から開けない孤児」になっていた。route.tsxにisSafeLogicalPathを追加し、apiSchema.path/createApiSchema.pathの zod refine と、/api/contentのfrontMatter[pathKey]ランタイムチェックの両方で利用EmptyLogicalPathErrorの責務はそのまま（/のみのパスは下流に任せる）。これは/foo.html→foo.htmlの正規化を壊さないためroute.spec.tsに追加（create / save の両エンドポイント、複数の.././NUL パターン）Test plan
npx vitest run src/route.spec.ts— 49 → 61 tests passingyarn build --scope @burger-editor/local— typecheck + bundle 成功/foo.htmlをfoo.htmlに正規化して受理」テストは引き続きパス