fix(kamado): correct lifecycle hook parameter types from Config to Context#75
Merged
YusukeHirao merged 1 commit intomainfrom Feb 4, 2026
Merged
fix(kamado): correct lifecycle hook parameter types from Config to Context#75YusukeHirao merged 1 commit intomainfrom
YusukeHirao merged 1 commit intomainfrom
Conversation
…ntext The onBeforeBuild and onAfterBuild hooks were typed to receive Config, but the implementation actually passes Context (which includes mode). This aligns the types with both the implementation and documentation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onBeforeBuildandonAfterBuildlifecycle hooksConfigtoContextto match actual implementationDetails
The lifecycle hooks were typed to receive
Config, but the implementation inbuild.tsactually passesContext(which extendsConfigand includes themodefield). This fix aligns the type definitions with:await context.onBeforeBuild?.(context))Context)Test plan
yarn lintpassesyarn buildpassesnpx vitest runpasses (178 tests)🤖 Generated with Claude Code