Merged
Conversation
祖先になり得るのはディレクトリ(stemが'/'で終わるノード)のみであるため、
startsWith判定の前にurl.stem.endsWith('/')を追加。
これにより /foo/bar.html が /foo/bar_baz.html の祖先と誤判定される問題を修正。
Closes #866
https://claude.ai/code/session_01KTVELzSgVqvC97KB73S6RF
- 同名プレフィックスのディレクトリとファイルが共存するケース - currentPathがルートの場合 - 深いネストでの祖先チェーン検証 https://claude.ai/code/session_01KTVELzSgVqvC97KB73S6RF
hasConfigFileガード内ではlistfileは必ず存在するため 非nullアサーション(!)が正しい。削除するとTS2345エラーになる。 https://claude.ai/code/session_01KTVELzSgVqvC97KB73S6RF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pathListToTreeのisAncestor判定で、startsWithのみの判定だったため/foo/bar.htmlが/foo/bar_baz.htmlの祖先と誤判定される問題を修正/で終わるノード）のみであるため、url.stem.endsWith('/')チェックを追加Closes #866
Test plan
https://claude.ai/code/session_01KTVELzSgVqvC97KB73S6RF