Merged
Conversation
Epicpkmn11
approved these changes
Mar 21, 2025
Contributor
Epicpkmn11
left a comment
Epicpkmn11
left a comment
There was a problem hiding this comment.
This looks good, I just stuck with the arbitrary buffers because that's how it was before, but I kept running into issues with the CJK ones cause well... Those fonts get large.
Wolfvak
approved these changes
May 10, 2025
Owner
|
Merged, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix buffer allocation properly so Chinese fonts can be loaded properly
(without this fix, it can only be loaded when switching language since it's the only place that allocate buffer by font size)