This repository was archived by the owner on Jul 1, 2025. It is now read-only.
allows Line shapes to be color by colorScale value#182
Merged
ffigueroal merged 1 commit intomasterfrom Jul 18, 2022
Merged
Conversation
ffigueroal
approved these changes
Jul 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lineshapes have a staticcolorAssignfunction in the default config, which overwrites thecolorScalelogic that is typically interited by the defaultshapeConfig.fillin theVizclass.Removing this one line allows Lines to be colored using
colorScale, with one caveat:If users do not want the
sumof all values in a Line to be used, then they must define a customaggsfunction.As an example, here is how you would color something using the max value (cc @AlanORB):