Skip to content
This repository was archived by the owner on Jul 1, 2025. It is now read-only.

sets timelineConfig.brushMin to 2 when time is on an axis#183

Merged
ffigueroal merged 2 commits intomasterfrom
fix/brushMin-time-axes
Jul 28, 2022
Merged

sets timelineConfig.brushMin to 2 when time is on an axis#183
ffigueroal merged 2 commits intomasterfrom
fix/brushMin-time-axes

Conversation

@davelandry
Copy link
Copy Markdown
Member

Was testing with this DataMexico quarterly data:

const data = "https://dev-api.datamexico.org/tesseract/data.jsonrecords?cube=fdi_9_quarter_investment&drilldowns=Quarter&measures=Investment";

new d3plus.LinePlot()
  .data(data, resp => resp.data)
  .config({
    groupBy: d => "Line",
    locale: "es-ES",
    time: "Quarter",
    x: "Quarter",
    y: "Investment"
  })
  .render();

@davelandry davelandry requested a review from ffigueroal July 26, 2022 18:20
@davelandry davelandry self-assigned this Jul 26, 2022
@ffigueroal ffigueroal merged commit ca009e7 into master Jul 28, 2022
@ffigueroal
Copy link
Copy Markdown
Contributor

Looks great @davelandry! I also tested it with monthly and yearly data from the OEC.

@ffigueroal ffigueroal deleted the fix/brushMin-time-axes branch July 28, 2022 14:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants