Skip to content

chore: promote dev to main — config v0.17.0 (Mantis #1221, audit COMPLIANT)#6

Merged
Snider merged 1 commit into
mainfrom
dev
Apr 30, 2026
Merged

chore: promote dev to main — config v0.17.0 (Mantis #1221, audit COMPLIANT)#6
Snider merged 1 commit into
mainfrom
dev

Conversation

@Snider

@Snider Snider commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Closes Mantis #1221.

Summary by CodeRabbit

  • Bug Fixes

    • Configuration broadcast failures now emit diagnostic warnings, improving troubleshooting visibility.
    • File watcher operation failures are now reported with warnings instead of being silently ignored, providing better error diagnostics.
  • Chores

    • Updated project dependencies.

audit.sh verdict: COMPLIANT (every counter at 0).

Closes tasks.lthn.sh/view.php?id=1221

Co-authored-by: Codex <noreply@openai.com>
@Snider Snider merged commit 34004ca into main Apr 30, 2026
2 of 4 checks passed
@coderabbitai

coderabbitai Bot commented Apr 30, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 425a0c5d-9b9a-4392-83c8-e98cd91840f3

📥 Commits

Reviewing files that changed from the base of the PR and between 02843fd and a91916d.

⛔ Files ignored due to path filters (1)
  • go/go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • go/config.go
  • go/go.mod
  • go/watch.go

📝 Walkthrough

Walkthrough

The changes introduce a new reportConfigBroadcast helper function that improves error handling for configuration broadcasting events. Previously, broadcast failures were silently discarded; now they emit warnings with source and error details. Additionally, the go.mod dependency on dappco.re/go/log is removed.

Changes

Cohort / File(s) Summary
Error handling and broadcast improvements
go/config.go, go/watch.go
Added reportConfigBroadcast helper to route ConfigChanged broadcast results and emit warnings when broadcasts fail. Enhanced error reporting in StopWatch and watchLoop to emit warnings for watcher close and path re-add failures.
Dependency management
go/go.mod
Removed direct dependency on dappco.re/go/log v0.9.0 from the module requirements.

Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant