Dev

[Snider]

Summary by CodeRabbit

Release Notes

• New Features

  • New initialisation methods for application components and configuration.
  • New service registration and lifecycle management system with automatic event handling.
  • Enhanced options builder API for simplified configuration construction.

• Refactor

  • Streamlined application startup and shutdown lifecycle via unified runtime method.
  • Improved service resolution with type-safe accessors.
  • Converted global state to per-instance isolation for thread safety.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 36d9554e-6192-4dd4-8586-d6ae79de9fd3

📥 Commits

Reviewing files that changed from the base of the PR and between a6be0df and f6ed40d.

📒 Files selected for processing (26)

• app.go
• app_test.go
• cli.go
• cli_test.go
• command.go
• command_test.go
• config.go
• contract.go
• contract_test.go
• core.go
• core_test.go
• data.go
• data_test.go
• drive.go
• drive_test.go
• embed.go
• embed_test.go
• fs.go
• i18n_test.go
• ipc.go
• lock.go
• options.go
• options_test.go
• runtime.go
• service.go
• service_test.go

---

📝 Walkthrough

Walkthrough

This PR refactors the core framework with a functional options pattern, service-oriented architecture, and improved resource isolation. Changes include restructuring the App and Options APIs, converting Cli to a registered service, introducing CoreOption functional options, and adding lifecycle management via RegisterService with auto-wired Startup/Shutdown hooks and IPC event handling.

Changes

Cohort / File(s)	Summary
Core constructor and options refactoring contract.go, contract_test.go, core.go, core_test.go	Replaced New(opts ...Options) with New(opts ...CoreOption). Added functional option helpers (WithOptions, WithService, WithName, WithOption, WithServiceLock) supporting service registration and initialization. Added Core.Run() lifecycle method. Changed Cli() to dynamically resolve from services instead of stored field.
Service management and registration service.go, service_test.go	Added RegisterService() for service registration with auto-wired lifecycle callbacks (OnStartup, OnShutdown) and IPC event handling. Extended Service struct with Instance field. Added typed accessors ServiceFor[T]() and MustServiceFor[T](). Updated Service() retrieval to return instance when available.
CLI refactoring to service-based cli.go, cli_test.go	Converted Cli to embed *ServiceRuntime[CliOptions]. Added CliRegister() function for CLI service registration. Updated option construction to use NewOptions() builder pattern.
App and Find API restructuring app.go, app_test.go	Added exported fields to App struct (Filename, Path, Runtime). Introduced App.New() constructor method. Changed Find() from package-level function to App.Find() method. Updated tests to reflect new constructor and method signatures.
Options and Result API refactoring options.go, options_test.go, runtime.go	Changed Options from slice to struct with internal items field. Added NewOptions() constructor and Set() method. Enhanced Result with New() and Get() methods. Updated usage throughout codebase to use builder pattern.
Configuration and service utilities config.go, service.go	Added Config.New() initializer method. Added per-Core lock isolation in Lock struct, replacing global lock state (lock.go). Updated retrieval and accessor patterns across service classes.
Test infrastructure and examples command.go, command_test.go, data.go, data_test.go, drive.go, drive_test.go, embed.go, embed_test.go, fs.go, i18n_test.go, ipc.go	Updated documentation examples and test helper methods to use NewOptions() constructor. Added test helpers (mountTestData, mustMountTestFS). Changed Result construction from Result() to New() in multiple places (fs.go, embed.go). Added filesystem sandbox initialization via Fs.New().

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}