Conversation
Replace fmt, encoding/json, path/filepath with Core primitives. Keep filepath.Abs (no core equivalent). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Virgil <virgil@lethean.io>
Replace all prose description comments with concrete usage examples per AX principle 2. Remove comments that merely restate the type signature. All public types and functions now show realistic call-site examples with real values. Error handling and struct naming unchanged (already compliant). Co-Authored-By: Virgil <virgil@lethean.io>
…ith behaviour-led openers
Convert function and interface-method comments from "Foo returns/builds/sets X" (restatement of the
signature) to comments that state the behaviour or invariant an agent needs — removing prose
descriptions where a usage example already conveys the meaning (AX Principle 2). Also rename
TestAttentionSnapshotWithQueries to TestAttentionSnapshot_Good_HasQueries to follow the
TestFilename_Function_{Good,Bad,Ugly} naming convention (AX Principle 1).
Co-Authored-By: Virgil <virgil@lethean.io>
- Rename TestTypes_Good_InterfaceCompliance → TestInference_InterfaceCompliance_Good - Rename TestAttentionInspector_Good_InterfaceCompliance → TestInference_AttentionInspectorCompliance_Good (AX: TestFilename_Function_ convention) - Replace raw t.Fatal/t.Fatalf in TestAttentionSnapshot_Good_HasQueries with assert/require (consistent with rest of file) - Rename single-letter variables a/b → firstConfig/secondConfig in options_test.go and training_test.go idempotency tests - Rename m → metrics in TestGenerateMetrics_Good (m is used as TextModel throughout the file) - Rename a/b/c → firstList/secondList/thirdList in TestList_Good_IndependentSlices - Rename m → discovered in discover_test.go single-model assertions (m conflicts with TextModel idiom) - Improve Info() method doc: replace restatement comment with concrete field-access example Co-Authored-By: Virgil <virgil@lethean.io>
Round 4 AX sweep: replaced ambiguous single-character variables in non-trivial production contexts with self-describing names. - `b` → `backend` in Default() fallback loop (inference.go) - `m` → `model` in probeModelDir result construction (discover.go) - `o` → `opt` in ApplyGenerateOpts and ApplyLoadOpts loops (options.go) Co-Authored-By: Virgil <virgil@lethean.io>
Keep the concrete examples, remove the last description-first doc lines, and tighten one test section label so the public contract reads more like an agent-facing usage guide. Co-Authored-By: Virgil <virgil@lethean.io>
…t the AX design principles in ~/spec/r...' (#7) from agent/update-the-code-against-the-ax-design-pr into dev
- discover.go: replace os.ReadDir/os.ReadFile/filepath.Abs with
core.Fs (NewUnrestricted), core.JSONUnmarshalString, core.PathIsAbs
- inference_test.go: rename all tests to TestInference_Function_{Good,Bad,Ugly}
- options_test.go: rename all tests to TestOptions_Function_{Good,Bad,Ugly}
- training_test.go: rename all tests to TestTraining_Function_{Good,Bad,Ugly}
+ add Ugly (SkipsUnavailableBackend) and Good_TargetKeysIndependent tests
Co-Authored-By: Virgil <virgil@lethean.io>
… tests - discover_test.go: replace os.MkdirAll/os.WriteFile with core.Fs.EnsureDir/Write throughout createModelDir and all inline test helpers; removes the os import - options_test.go: add TestOptions_WithTopP_Bad, WithTopP_Ugly, WithRepeatPenalty_Bad, WithRepeatPenalty_Ugly — closes missing test coverage for out-of-range values that the options layer silently accepts - training_test.go: add LoRAConfig Bad (zero/negative Rank, zero Alpha) and Ugly (empty/nil TargetKeys, BFloat16+high-rank) tests Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 9 minutes and 32 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (10)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module path migration from forge.lthn.ai to dappco.re