chore(dev→main): routine PR cadence for CodeRabbit review

[Snider]

Routine dev→main PR opened by Hephaestus PR-cadence task.

This PR exists to:

1. Trigger CodeRabbit auto-review of accumulated dev work
2. Surface any blocking review feedback before merge
3. Keep main current with dev once approved

ahead_by: 32 commit(s) (per gh api compare)

If CodeRabbit clears with no blocking comments, this PR is eligible for gh pr merge --merge (real merge commit, no force-push). Conflicts and review feedback should be addressed on the dev branch before merge.

Co-authored-by: Hephaestus hephaestus@cladius

[coderabbitai]

Warning

Rate limit exceeded

@Snider has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minutes and 33 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6dada3cb-0569-4d31-98f4-54ca39a4686e

📥 Commits

Reviewing files that changed from the base of the PR and between ed4c3fa and 68f2b01.

⛔ Files ignored due to path filters (2)

• go.sum is excluded by !**/*.sum
• go.work is excluded by !**/*.work

📒 Files selected for processing (19)

• CLAUDE.md
• README.md
• discover.go
• discover_test.go
• docs/RFC.models.md
• docs/architecture.md
• docs/backends.md
• docs/development.md
• docs/index.md
• docs/types.md
• go.mod
• inference.go
• inference_test.go
• options.go
• options_test.go
• test_helpers_test.go
• tests/cli/inference/Taskfile.yaml
• training.go
• training_test.go

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Snider]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[Copilot]

Pull request overview

Routine dev→main sync that updates the module identity and strengthens core inference behaviors while refactoring tests and discovery utilities.

Changes:

• Renames the module path to dappco.re/go/inference and updates docs/README accordingly.
• Improves runtime robustness in model/trainable loading (nil model handling, consistent error wrapping) and updates generation defaults (RepeatPenalty = 1.0).
• Replaces many testify assertions with local check* helpers and expands test coverage; adds a Taskfile for CLI test workflows.

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
go.mod	Module path rename; Go version set; dependencies reorganized.
go.work	Adds workspace file pinning toolchain version.
go.sum	Updates dependency checksums (currently inconsistent with go.mod).
README.md	Updates module path/docs; adjusts badges/links (license + Go version need alignment).
docs/index.md	Updates import/module references to new module path.
docs/types.md	Updates module path reference; documents RepeatPenalty default.
docs/development.md	Updates module path; adjusts stated Go prerequisite (needs alignment with go.mod/go.work).
docs/backends.md	Updates import paths and example backend blank imports.
docs/architecture.md	Updates module path and default GenerateConfig behavior docs.
docs/RFC.models.md	Adds draft RFC placeholder.
options.go	Sets RepeatPenalty default to 1.0; clones stop-token slices; ignores nil options.
options_test.go	Migrates to check* helpers; adds tests for nil options + stop-token copy isolation.
test_helpers_test.go	Introduces local assertion helpers to replace testify usage.
inference.go	Registry mutex source change; adds nil-backend no-op; improves Default/LoadModel erroring/wrapping; nil-model checks.
inference_test.go	Migrates to check* helpers; adds tests for ordering/determinism and nil scenarios (currently has duplicate tests + leftover testify usage).
training.go	Adds nil-model guard in LoadTrainable; improves error structure.
training_test.go	Migrates to check* helpers; adds nil-model coverage.
discover.go	Rewrites Discover traversal to use core.Fs + deterministic ordering (absolute path logic currently incorrect).
discover_test.go	Migrates many tests to stdlib fs fixtures + check*; adds more cases (still contains leftover testify usage later).
tests/cli/inference/Taskfile.yaml	Adds task runner commands for build/test/vet workflows.

Comments suppressed due to low confidence (3)

inference_test.go:199

• Duplicate test function name TestInference_All_Good_SortedOrder appears twice in this file; the second copy also still calls assert.Equal even though testify imports were removed. This will not compile—please delete/rename the duplicate test and convert the remaining assertions to the local check* helpers (or re-add/testify if that's the intent).

func TestInference_All_Good_SortedOrder(t *testing.T) {
	resetBackends(t)

	Register(&stubBackend{name: "beta", available: true})
	Register(&stubBackend{name: "alpha", available: true})

inference_test.go:284

• TestInference_Default_Good_AlphabeticalFallback is defined twice; the later copy still uses require.NoError/assert.Equal without importing testify anymore. This causes duplicate symbol + missing identifier compile errors—remove/merge the duplicate and use the check* helpers consistently.

func TestInference_Default_Good_AlphabeticalFallback(t *testing.T) {
	resetBackends(t)

	Register(&stubBackend{name: "zeta", available: true})
	Register(&stubBackend{name: "alpha", available: true})

discover_test.go:320

• TestDiscover_Good_RecursiveNestedModels is reintroduced a second time later in the file (duplicate function name). The later block also uses core.Path and testify require/assert even though the file no longer imports testify. Please remove/rename the duplicate and migrate the assertions to check* (and use the same path-joining approach as the rest of the file).

func TestDiscover_Good_RecursiveNestedModels(t *testing.T) {
	base := t.TempDir()
	createModelDir(t, core.Path(base, "models"), map[string]any{
		"model_type": "parent",
	}, 1)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

README links to LICENSE.md here, but later in the same file it references [LICENCE](LICENCE) and the repository root currently contains neither file. Please add the actual license file (and pick one consistent filename/link) so the badge and licence section aren’t broken.

[Copilot]

absolutePath can return a relative path when dir is relative and DIR_CWD is unset (it falls back to cleanPath(dir)). That violates the DiscoveredModel.Path contract (“Absolute path”) and will break callers/tests expecting filepath.IsAbs(Path) to be true. Prefer computing an actual absolute path (e.g., via the real working directory + join/clean, or filepath.Abs).

[Copilot]

The README is inconsistent about the Go version: the badge shows Go 1.26, but the “Language” line says Go 1.25, while go.mod/go.work specify Go 1.26.0. Please make these consistent to avoid confusing consumers and contributors.

Suggested change

	**Language**: Go 1.25
	**Language**: Go 1.26

[Copilot]

Docs say “Go 1.25 or later”, but this PR sets go.mod/go.work to Go 1.26.0. Please align the documented prerequisite with the actual go directives (or lower the directives if 1.25 is sufficient).

Suggested change

	- Go 1.25 or later (uses `iter.Seq` from Go 1.23 and range-over-function from 1.22)
	- Go 1.26 or later (uses `iter.Seq` from Go 1.23 and range-over-function from 1.22)

[Copilot]

go.mod still requires github.com/stretchr/testify, but the updated tests in this PR have largely switched to local check* helpers and no Go files reference testify anymore. If the remaining testify usage is accidental, consider dropping the dependency (and running go mod tidy) to keep the module truly stdlib-only.

[Copilot]

This file drops testify imports, but there are still require.* / assert.* calls later in the file (e.g. the second TestDiscover_Good_RecursiveNestedModels block near the end). As-is the test package won’t compile—either remove/convert those remaining testify assertions to check*, or keep the testify imports until the migration is complete.

Suggested change

	"dappco.re/go/core"
	"dappco.re/go/core"
	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"

[Copilot]

pathSeparator() defaults to "/" unless the non-standard DS env var is set. On Windows this will produce incorrect paths for fsys.List / fsys.Read and can prevent discovery from working at all. Consider using the OS path separator (os.PathSeparator/filepath.Separator) rather than an env override, or at least default to the OS separator when DS is not set.