Skip to content

go update#4

Merged
Snider merged 1 commit intomainfrom
dev
Mar 20, 2026
Merged

go update#4
Snider merged 1 commit intomainfrom
dev

Conversation

@Snider
Copy link
Copy Markdown
Contributor

@Snider Snider commented Mar 20, 2026

Summary by CodeRabbit

  • Chores
    • Updated package import paths throughout test files and core modules.
    • Applied consistent whitespace alignment and formatting adjustments across multiple files to improve code consistency.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b7f2e12a-19fa-4738-aff1-e223b7f58c6c

📥 Commits

Reviewing files that changed from the base of the PR and between d6dada1 and b34899c.

⛔ Files ignored due to path filters (1)
  • go/go.sum is excluded by !**/*.sum
📒 Files selected for processing (48)
  • go/.golangci.yml
  • go/core/app.go
  • go/core/array.go
  • go/core/cli.go
  • go/core/command.go
  • go/core/config.go
  • go/core/contract.go
  • go/core/core.go
  • go/core/data.go
  • go/core/drive.go
  • go/core/embed.go
  • go/core/error.go
  • go/core/fs.go
  • go/core/i18n.go
  • go/core/ipc.go
  • go/core/lock.go
  • go/core/log.go
  • go/core/options.go
  • go/core/runtime.go
  • go/core/service.go
  • go/core/string.go
  • go/core/task.go
  • go/core/utils.go
  • go/go.mod
  • go/tests/app_test.go
  • go/tests/array_test.go
  • go/tests/cli_test.go
  • go/tests/command_test.go
  • go/tests/config_test.go
  • go/tests/core_test.go
  • go/tests/data_test.go
  • go/tests/drive_test.go
  • go/tests/embed_test.go
  • go/tests/error_test.go
  • go/tests/fs_test.go
  • go/tests/i18n_test.go
  • go/tests/ipc_test.go
  • go/tests/lock_test.go
  • go/tests/log_test.go
  • go/tests/options_test.go
  • go/tests/runtime_test.go
  • go/tests/service_test.go
  • go/tests/string_test.go
  • go/tests/task_test.go
  • go/tests/testdata/cli_clir.go.bak
  • go/tests/testdata/scantest/sample.go
  • go/tests/testdata/test.txt
  • go/tests/utils_test.go
💤 Files with no reviewable changes (1)
  • go/core/app.go

📝 Walkthrough

Walkthrough

This PR refactors import paths across the codebase from dappco.re/go/core/pkg/core to dappco.re/go/core, alongside minor whitespace and formatting adjustments in struct field declarations throughout the core package.

Changes

Cohort / File(s) Summary
Core Package Formatting
go/core/app.go, go/core/config.go, go/core/lock.go, go/core/service.go, go/core/task.go
Whitespace and alignment adjustments in struct field declarations; no functional or semantic changes.
Core Import Path Update
go/core/embed.go
Updated generated Go pack content import from dappco.re/go/core/pkg/core to dappco.re/go/core.
Test Import Path Refactoring
go/tests/app_test.go, go/tests/array_test.go, go/tests/cli_test.go, go/tests/command_test.go, go/tests/config_test.go, go/tests/core_test.go, go/tests/data_test.go, go/tests/drive_test.go, go/tests/embed_test.go, go/tests/error_test.go, go/tests/fs_test.go, go/tests/ipc_test.go, go/tests/lock_test.go, go/tests/log_test.go, go/tests/options_test.go, go/tests/runtime_test.go, go/tests/service_test.go, go/tests/string_test.go, go/tests/task_test.go, go/tests/utils_test.go, go/tests/testdata/scantest/sample.go
Updated all test file dot-imports from dappco.re/go/core/pkg/core to dappco.re/go/core; affects identifier resolution during compilation and testing.
Test Code Formatting
go/tests/i18n_test.go
Expanded mockTranslator method bodies from single-line to multi-line format; no functional changes to logic or return values.
🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'go update' is vague and generic, using non-descriptive language that fails to convey the specific nature of the changeset. Provide a more descriptive title that clearly summarises the main changes, such as 'Update import paths from dappco.re/go/core/pkg/core to dappco.re/go/core' or 'Refactor core package import paths and adjust struct field formatting'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@Snider Snider merged commit dcf6773 into main Mar 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant