chimera: applying attributes to newly created file should skip permis…#8098
Merged
Conversation
…sion check Motivation: File creation with non basic attributes is now an atomic operation, as the namespace provided can implement it as create+set attr. If the initial file attributes doesn't allow `set attribute` operation, then such create request will fail. Example: directory `dir` has inherit-only ACL: 'DENY WRITE_ATTRIBUTE for EVRYONE' that applies to each newly created file. A new file is crated with pre-defeined extended attribute. Then after create, the applying xattrs will fail, as ACL rejects it. Modification: On create, skip permission check when applying the attributes that are a part of the initial request. Result: The initial, non basic attributes can be applied on create. Fixes: #8035 Acked-by: Dmitry Litvintsev Target: master, 11.2, 11.1, 11.0, 10.2 Require-book: no Require-notes: yes (cherry picked from commit 6970263) Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sion check
Motivation:
File creation with non basic attributes is now an atomic operation, as the namespace provided can implement it as create+set attr. If the initial file attributes doesn't allow
set attributeoperation, then such create request will fail.Example:
directory
dirhas inherit-only ACL: 'DENY WRITE_ATTRIBUTE for EVRYONE' that applies to each newly created file. A new file is crated with pre-defeined extended attribute. Then after create, the applying xattrs will fail, as ACL rejects it.Modification:
On create, skip permission check when applying the attributes that are a part of the initial request.
Result:
The initial, non basic attributes can be applied on create.
Fixes: #8035
Acked-by: Dmitry Litvintsev
Target: master, 11.2, 11.1, 11.0, 10.2
Require-book: no
Require-notes: yes
(cherry picked from commit 6970263)