chore: tooling refresh (prettier 3 + eslint 8 + typescript-eslint 7)#950
Merged
Merged
Conversation
Bumps: - prettier 2.8.8 -> 3.8.3 - eslint 7.32.0 -> 8.57.1 - eslint-config-prettier 8 -> 10 - eslint-plugin-prettier 4 -> 5 - @typescript-eslint/* 6 -> 7.18.0 (latest 7.x; 8.x requires type-aware parser config with parserOptions.project, which would need a real .eslintrc and tsconfig integration — left for a later pass) Other changes: - lint scripts switched from quoted glob to --ext flag so eslint 8 resolves files correctly on Windows (single-quoted globs aren't expanded by bash on win32 the way 7 tolerated) - Added .prettierignore to skip contract ABIs (hand-aligned vendor JSON) and build artifacts - 12 src files reformatted by prettier 3 (mostly argument-wrapping on long function calls; explicit config in .prettierrc.json prevented trailingComma/arrowParens churn) yarn build, yarn lint:check, tsc --noEmit all green.
✅ Deploy Preview for tezos-homebase ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refreshes the linting and formatting toolchain to current stable lines. No runtime/source behavior change beyond mechanical reformatting.
prettier2 → 3eslint7 → 8eslint-config-prettier8 → 10eslint-plugin-prettier4 → 5@typescript-eslint/*6 → 7.18.0 (latest 7.x — see note below)Notes for review
parserOptions.projectpointing attsconfig.json). Adding that is a separate ticket — would change lint scope from syntactic to full type-checked, with its own perf and rule-set implications. v7 is the cleanest interim step.'src/**/*.{js,jsx,ts,tsx}'glob with literal single quotes worked on eslint 7 but not eslint 8 on Windows bash. Replaced with--ext .js,.jsx,.ts,.tsx src..prettierignoreto skip the contract ABIs insrc/assets/abis/— those JSON files are hand-column-aligned for readability and shouldn't be reformatted. Build output and lockfiles also ignored..prettierrc.jsonalready set every default that changed in v3 (trailingComma, arrowParens, etc.), so the only changes are argument-wrapping on a few long function calls.Test plan
yarn install— cleanyarn build— greennpx tsc --noEmit— greenyarn lint:check— green