docs(composite): Epic #150 Phase 1.3 smoke-test — composite.py docstring cross-ref#153
Merged
Merged
Conversation
…ing cross-ref Throwaway PR to dogfood the pre-merge-prod-sim workflow (PR #148 + #149). The workflow's path filter triggers on `compute/scoring/**` or `compute/features/**`, but neither prior PR touched those paths — so the sticky-comment + diff-table composition has never run end-to-end in CI. This PR adds a 3-line docstring cross-reference in `composite.py` to epic #150 Phase 3 (pillar correlation analysis + Quality+Profitability ROE double-counting). The cross-ref documents in code where the next structural work lives — useful regardless of smoke-test outcome. Composite logic is unchanged. PHASE3_WEIGHTS unchanged. sum-to-1.0 invariant lock at composite.py:43-45 unchanged. CLAUDE.md + AGENTS.md lockstep update.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Pre-merge production simulation
Diff vs main
Main baseline: Top-10 movers (sorted by |Δcomposite_score|)
|
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Epic #150 Phase 1.3 — smoke-test for pre-merge-prod-sim workflow.
The
pre-merge-prod-sim.ymlworkflow (shipped via PR #148 + PR #149) is gated bycompute/scoring/**orcompute/features/**path filters. Neither PR #148 nor PR #149 touched those paths, so the sticky-comment + diff-table composition has never run end-to-end in CI. This PR is the first real dogfood.What this PR does
Adds a 3-line docstring cross-reference in
compute/scoring/composite.pypointing to epic #150 Phase 3 (pillar correlation analysis + Quality + Profitability ROE double-counting at ~33% effective composite weight on ROE signals).No compute logic change:
PHASE3_WEIGHTSunchangedcomposite.py:43-45unchangedACTIVE_PILLARS_PHASE3/INACTIVE_PILLARS_PHASE3unchangedThe cross-reference is a real documentation improvement — points future readers to where the structural work lives. Useful regardless of smoke-test outcome.
Expected workflow behavior (verification matrix)
compute/scoring/composite.py)universe_size,version,git_commitpopulatedgit show origin/main:frontend/public/data/*succeedspr-152-compute-outputartifact (14-day retention)Expected diff result: Composite scores should be identical between PR-branch and main (docstring-only change, no scoring logic). Top-10 movers table should show all-zero deltas (with ticker-asc tiebreaker — same pattern as the dogfood I ran locally earlier).
If anything else fires (non-zero deltas, missing diff section, failure-path comment) — that's the workflow telling us something. This PR is purely an observability test.
Plan after this PR
If workflow ✅ green and diff renders correctly:
If workflow fails:
Constraints honored
workflow_dispatchtriggerGenerated by Claude Code — Epic #150 Phase 1.3 smoke-test
Generated by Claude Code